extensions/browser/pending_extension_manager.h - Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/pending_extension_manager.h

Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed @finnur comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/settings_override/manifest.json ('K') | « extensions/browser/pending_extension_info.cc ('k') | extensions/browser/pending_extension_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/pending_extension_manager.h

diff --git a/extensions/browser/pending_extension_manager.h b/extensions/browser/pending_extension_manager.h

index beedc059e9089cca8558c44ea7c552478ad903d4..c3e180f31be2e2b3d240bd9e578a78261a4f8bea 100644

--- a/extensions/browser/pending_extension_manager.h

+++ b/extensions/browser/pending_extension_manager.h

@@ -90,6 +90,7 @@ class PendingExtensionManager {

// Given an extension id and an update URL, schedule the extension

// to be fetched, installed, and activated.

bool AddFromExternalUpdateUrl(const std::string& id,

+ const std::string& install_parameter,

const GURL& update_url,

Manifest::Location location,

int creation_flags,

@@ -118,6 +119,7 @@ class PendingExtensionManager {

// Return true if the extension was added.

bool AddExtensionImpl(

const std::string& id,

+ const std::string& install_parameter,

const GURL& update_url,

const base::Version& version,

PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install,