Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modified test parameters Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_browsertest.cc
diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc
index 29bedb23ca749ace32d10873f9e34fadaa986225..c0aec958fec4ce2c4be0fb3d7b08d31af6f6ea4d 100644
--- a/chrome/browser/extensions/api/management/management_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_browsertest.cc
@@ -425,8 +425,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {
// of external_extensions.json before this test function starts.
EXPECT_TRUE(pending_extension_manager->AddFromExternalUpdateUrl(
- kExtensionId, GURL("http://localhost/autoupdate/manifest"),
- Manifest::EXTERNAL_PREF_DOWNLOAD, Extension::NO_FLAGS, false));
+ kExtensionId,
+ std::string(),
+ GURL("http://localhost/autoupdate/manifest"),
+ Manifest::EXTERNAL_PREF_DOWNLOAD,
+ Extension::NO_FLAGS,
+ false));
// Run autoupdate and make sure version 2 of the extension was installed.
service->updater()->CheckNow(params);
@@ -449,8 +453,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {
// Try to install the extension again from an external source. It should fail
// because of the killbit.
EXPECT_FALSE(pending_extension_manager->AddFromExternalUpdateUrl(
- kExtensionId, GURL("http://localhost/autoupdate/manifest"),
- Manifest::EXTERNAL_PREF_DOWNLOAD, Extension::NO_FLAGS, false));
+ kExtensionId,
+ std::string(),
+ GURL("http://localhost/autoupdate/manifest"),
+ Manifest::EXTERNAL_PREF_DOWNLOAD,
+ Extension::NO_FLAGS,
+ false));
EXPECT_FALSE(pending_extension_manager->IsIdPending(kExtensionId))
<< "External reinstall of a killed extension shouldn't work.";
EXPECT_TRUE(extension_prefs->IsExternalExtensionUninstalled(kExtensionId))

Powered by Google App Engine
This is Rietveld 408576698