Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2161)

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 196663003: Introduce an extension parameter which is used to customize the extension. It's available for exter… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_provider_impl.cc
diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc
index 5f73465280c4edf7393f9ad2e58c64e8d6a92528..323ea4d7ee6103b9b71d56e25722a02c690975c9 100644
--- a/chrome/browser/extensions/external_provider_impl.cc
+++ b/chrome/browser/extensions/external_provider_impl.cc
@@ -55,6 +55,7 @@ using content::BrowserThread;
namespace extensions {
// Constants for keeping track of extension preferences in a dictionary.
+const char ExternalProviderImpl::kInstallParam[] = "install_parameter";
const char ExternalProviderImpl::kExternalCrx[] = "external_crx";
const char ExternalProviderImpl::kExternalVersion[] = "external_version";
const char ExternalProviderImpl::kExternalUpdateUrl[] = "external_update_url";
@@ -220,6 +221,9 @@ void ExternalProviderImpl::SetPrefs(base::DictionaryValue* prefs) {
}
}
+ std::string install_parameter;
+ extension->GetString(kInstallParam, &install_parameter);
+
if (has_external_crx) {
if (crx_location_ == Manifest::INVALID_LOCATION) {
LOG(WARNING) << "This provider does not support installing external "
@@ -271,9 +275,12 @@ void ExternalProviderImpl::SetPrefs(base::DictionaryValue* prefs) {
<< "\", which is not a valid URL.";
continue;
}
- service_->OnExternalExtensionUpdateUrlFound(
- extension_id, update_url, download_location_, creation_flags,
- auto_acknowledge_);
+ service_->OnExternalExtensionUpdateUrlFound(extension_id,
+ install_parameter,
+ update_url,
+ download_location_,
+ creation_flags,
+ auto_acknowledge_);
}
}

Powered by Google App Engine
This is Rietveld 408576698