Roll buildtools 731bdb2af8..fed41029f6

Roll buildtools 731bdb2af8..fed41029f6

  In order to roll GN 6d7b5d9014..1b82fc15fe (r389592:r392565) and pick up
  the following changes:

  66bbbab GN: Prefer toplevel targets for phony names.
  a5b852c GN: Don't import a file more than once.
  8c8c59e Fix GN bootstrap
  aec64c1 Remove reference to old gn win x64 bot in roll_gn.py.
  6ee04b5 [GN] Add support for generating Xcode projects.
  0785c95 GN: forward_variables_from shouldn't clobber vars.
  cc00b40 GN: Add common header extensions
  c86fe93 GN: fix bootstrap
  f2347fc gn: Stop printing all help when the command is unknown
  d4fed18 Renaming system.gyp:ssl to system.gyp:nss and removing unused BUILD.gn
  b68180a Fix arm detection code in gn.
  f9f7d62 Add manifests to many more gn built exe files

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg

[sdefresne, 2016-05-10 08:43:57]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-05-10 08:44:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966613002/1

[commit-bot: I haz the power, 2016-05-10 09:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 09:45:15]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sdefresne, 2016-05-10 10:16:12]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-05-10 10:16:13]

On 2016/05/10 09:45:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Hum, it looks like regeneration of ninja files by gn does not stabilize for that
single bot (i.e. it fails with the following errors):

/b/build/scripts/slave/.recipe_deps/depot_tools/ninja -w dupbuild=err -C
/b/build/slave/linux_clobber/build/src/out/Release all chrome -j50
ninja: Entering directory `/b/build/slave/linux_clobber/build/src/out/Release'
[1/1] Regenerating ninja files
... many lines ommitter ...
[1/1] Regenerating ninja files
ninja: error: manifest 'build.ninja' still dirty after 100 tries

I am unable to reproduce locally.

dpranke/brettw: do you have an idea of what could cause this bot to fail?

[Dirk Pranke, 2016-05-10 20:55:00]

On 2016/05/10 10:16:13, sdefresne wrote:
> On 2016/05/10 09:45:15, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Hum, it looks like regeneration of ninja files by gn does not stabilize for
that
> single bot (i.e. it fails with the following errors):
> 
> /b/build/scripts/slave/.recipe_deps/depot_tools/ninja -w dupbuild=err -C
> /b/build/slave/linux_clobber/build/src/out/Release all chrome -j50
> ninja: Entering directory `/b/build/slave/linux_clobber/build/src/out/Release'
> [1/1] Regenerating ninja files
> ... many lines ommitter ...
> [1/1] Regenerating ninja files
> ninja: error: manifest 'build.ninja' still dirty after 100 tries
> 
> I am unable to reproduce locally.
> 
> dpranke/brettw: do you have an idea of what could cause this bot to fail?

The only time I've seen that is when I've renamed/moved a directory or used
symlinks and
GN has gotten confused by that, but that seems unlikely to be the case here.

I'd be more inclined to think some sort of bug has crept into GN.

[sdefresne, 2016-05-17 12:59:00]

On 2016/05/10 20:55:00, Dirk Pranke wrote:
> On 2016/05/10 10:16:13, sdefresne wrote:
> > On 2016/05/10 09:45:15, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > 
> > Hum, it looks like regeneration of ninja files by gn does not stabilize for
> that
> > single bot (i.e. it fails with the following errors):
> > 
> > /b/build/scripts/slave/.recipe_deps/depot_tools/ninja -w dupbuild=err -C
> > /b/build/slave/linux_clobber/build/src/out/Release all chrome -j50
> > ninja: Entering directory
`/b/build/slave/linux_clobber/build/src/out/Release'
> > [1/1] Regenerating ninja files
> > ... many lines ommitter ...
> > [1/1] Regenerating ninja files
> > ninja: error: manifest 'build.ninja' still dirty after 100 tries
> > 
> > I am unable to reproduce locally.
> > 
> > dpranke/brettw: do you have an idea of what could cause this bot to fail?
> 
> The only time I've seen that is when I've renamed/moved a directory or used
> symlinks and
> GN has gotten confused by that, but that seems unlikely to be the case here.
> 
> I'd be more inclined to think some sort of bug has crept into GN.

Obsolete, brettw fixed the gn issue and rolled past it.