Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 19666006: Supports FontList in Textfield. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes examples and unittests. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/native_textfield_views.cc
diff --git a/ui/views/controls/textfield/native_textfield_views.cc b/ui/views/controls/textfield/native_textfield_views.cc
index 31687afa180b6ef02987f1d6793e22dfeb1a9ed0..b24edbb688934936af7faa5d8d08297f8da7fbad 100644
--- a/ui/views/controls/textfield/native_textfield_views.cc
+++ b/ui/views/controls/textfield/native_textfield_views.cc
@@ -82,14 +82,7 @@ NativeTextfieldViews::NativeTextfieldViews(Textfield* parent)
cursor_timer_(this),
aggregated_clicks_(0) {
set_border(text_border_);
-
-#if defined(OS_CHROMEOS)
- GetRenderText()->SetFontList(gfx::FontList(l10n_util::GetStringUTF8(
msw 2013/07/26 21:19:57 I think you'll need to leave this explicit IDS_UI_
Yuki 2013/07/29 15:27:21 Done. As the same as views::Label, I've introduce
- IDS_UI_FONT_FAMILY_CROS)));
-#else
- GetRenderText()->SetFont(textfield_->font());
-#endif
-
+ GetRenderText()->SetFontList(textfield_->font_list());
UpdateColorsFromTheme(GetNativeTheme());
set_context_menu_controller(this);
set_drag_controller(this);
@@ -575,13 +568,7 @@ void NativeTextfieldViews::UpdateReadOnly() {
}
void NativeTextfieldViews::UpdateFont() {
-#if defined(OS_CHROMEOS)
- // For ChromeOS, we support a pre-defined font list per locale. UpdateFont()
- // only changes the font size, not the font family names.
- GetRenderText()->SetFontSize(textfield_->font().GetFontSize());
-#else
- GetRenderText()->SetFont(textfield_->font());
-#endif
+ GetRenderText()->SetFontList(textfield_->font_list());
OnCaretBoundsChanged();
}
@@ -726,11 +713,11 @@ void NativeTextfieldViews::ClearEditHistory() {
}
int NativeTextfieldViews::GetFontHeight() {
- return GetRenderText()->GetFont().GetHeight();
+ return GetRenderText()->font_list().GetHeight();
}
int NativeTextfieldViews::GetTextfieldBaseline() const {
- return GetRenderText()->GetFont().GetBaseline();
+ return GetRenderText()->font_list().GetBaseline();
}
int NativeTextfieldViews::GetWidthNeededForText() const {
@@ -1166,7 +1153,7 @@ void NativeTextfieldViews::PaintTextAndCursor(gfx::Canvas* canvas) {
!textfield_->placeholder_text().empty()) {
canvas->DrawStringInt(
textfield_->placeholder_text(),
- GetRenderText()->GetFont(),
+ GetRenderText()->GetPrimaryFont(),
textfield_->placeholder_text_color(),
GetRenderText()->display_rect());
}

Powered by Google App Engine
This is Rietveld 408576698