Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1966563002: Extracted shell_interfaces and shell_public into a separate gyp file. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extracted shell_interfaces and shell_public into a separate gyp file. This change breaks components/filesystem/filesystem.gyp -> services/shell/shell.gyp -> components/filesystem/filesystem.gyp circular dependency which has been introduced here: https://codereview.chromium.org/1942473002/diff/320001/services/shell/shell.gyp and breaks runhooks on iOS as follows: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/2023/steps/gclient%20runhooks%20%28with%20patch%29/logs/stdio BUG=610554 Committed: https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a Cr-Commit-Position: refs/heads/master@{#393196}

Patch Set 1 #

Patch Set 2 : Fixed dependencies. #

Patch Set 3 : Actually fixed deps #

Patch Set 4 : Fixed export_dependent_settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -92 lines) Patch
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/filesystem.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_utility.gypi View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/shell.gyp View 1 2 3 6 chunks +8 lines, -74 lines 0 comments Download
A services/shell/shell_public.gyp View 1 chunk +75 lines, -0 lines 0 comments Download
M services/tracing/tracing.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/user/user.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966563002/1
4 years, 7 months ago (2016-05-10 02:25:12 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/209624)
4 years, 7 months ago (2016-05-10 02:29:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966563002/20001
4 years, 7 months ago (2016-05-10 02:52:18 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/197886) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 7 months ago (2016-05-10 02:55:51 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966563002/40001
4 years, 7 months ago (2016-05-10 15:26:09 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/198122) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 7 months ago (2016-05-10 15:29:59 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966563002/60001
4 years, 7 months ago (2016-05-10 16:09:01 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 17:24:18 UTC) #17
Eugene But (OOO till 7-30)
Please add ben@ if necessary.
4 years, 7 months ago (2016-05-10 17:29:16 UTC) #19
Ken Rockot(use gerrit already)
LGTM, I think you can safely TBR ben for the mechanical changes
4 years, 7 months ago (2016-05-10 23:17:08 UTC) #20
Eugene But (OOO till 7-30)
avi@ for content/ chcunningham@ for media/ erg@ for components, services/user and services/tracing
4 years, 7 months ago (2016-05-11 00:29:37 UTC) #21
Eugene But (OOO till 7-30)
Actually adding reviewers :) avi@ for content/ chcunningham@ for media/ erg@ for components, services/user and ...
4 years, 7 months ago (2016-05-11 22:36:23 UTC) #23
Elliot Glaysher
mechanical change lgtm
4 years, 7 months ago (2016-05-11 22:43:37 UTC) #24
chcunningham
lgtm
4 years, 7 months ago (2016-05-12 00:54:20 UTC) #25
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-12 01:47:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966563002/60001
4 years, 7 months ago (2016-05-12 05:01:04 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-12 06:26:24 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 06:27:49 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9b143c65c2e8b243e54b39359d4509d85f5fa72a
Cr-Commit-Position: refs/heads/master@{#393196}

Powered by Google App Engine
This is Rietveld 408576698