trunk/Source/core/css/MediaQuerySetTest.cpp - Issue 196653020: Revert 169289 "A thread-safe Media Query Parser"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/core/css/MediaQuerySetTest.cpp

Issue 196653020: Revert 169289 "A thread-safe Media Query Parser" (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/core/css/MediaQuerySetTest.cpp

===================================================================

--- trunk/Source/core/css/MediaQuerySetTest.cpp (revision 169291)

+++ trunk/Source/core/css/MediaQuerySetTest.cpp (working copy)

@@ -94,7 +94,7 @@

{"all and(color)", "not all"},

{"all and (", "not all"},

{"test;,all", "not all, all"},

- {"(color:20example)", "not all"},

+ // {"(color:20example)", "not all"}, // BisonCSSParser fails to parse that MQ, producing an infinitesimal float.

{"not braille", 0},

{",screen", "not all, screen"},

{",all", "not all, all"},

@@ -104,7 +104,7 @@

{",screen,,(invalid,),,", "not all, screen, not all, not all, not all, not all"},

{",(all,),,", "not all, not all, not all, not all"},

{",", "not all, not all"},

- {" ", ""},

+ // {" ", ""}, // BisonCSSParser fails to parse that MQ, producing "not all, not all".

{"(color", "(color)"},

{"(min-color: 2", "(min-color: 2)"},

{"(orientation: portrait)", 0},