Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 196653019: gpu: Add extension check when initializing MailboxSync (Closed)

Created:
6 years, 9 months ago by boliu
Modified:
6 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

gpu: Add extension check when initializing MailboxSync And do not enable accelerated canvas in webview if extensions are missing. BUG=332146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257295

Patch Set 1 #

Patch Set 2 : PreMainMessageLoopRun #

Patch Set 3 : allow kGLImplementationMockGL for tests #

Patch Set 4 : and mac should fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -9 lines) Patch
M android_webview/browser/aw_browser_main_parts.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/mailbox_synchronizer.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ui/gl/generate_bindings.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
boliu
6 years, 9 months ago (2014-03-14 20:53:54 UTC) #1
no sievers
lgtm
6 years, 9 months ago (2014-03-14 20:59:35 UTC) #2
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-14 21:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/196653019/20001
6 years, 9 months ago (2014-03-14 21:36:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-14 21:40:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-14 21:40:17 UTC) #6
boliu
PTAL PS3
6 years, 9 months ago (2014-03-14 23:02:22 UTC) #7
no sievers
lgtm
6 years, 9 months ago (2014-03-14 23:03:16 UTC) #8
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-14 23:07:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/196653019/60001
6 years, 9 months ago (2014-03-14 23:07:48 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 05:28:44 UTC) #11
Message was sent while issue was closed.
Change committed as 257295

Powered by Google App Engine
This is Rietveld 408576698