Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 196653009: Remove uses of RangeCanInclude() in flooring division by power of 2. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: RangeCanInclude() is gone now Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1391 matching lines...) Expand 10 before | Expand all | Expand 10 after
1402 return DoArithmeticD(Token::DIV, instr); 1402 return DoArithmeticD(Token::DIV, instr);
1403 } else { 1403 } else {
1404 return DoArithmeticT(Token::DIV, instr); 1404 return DoArithmeticT(Token::DIV, instr);
1405 } 1405 }
1406 } 1406 }
1407 1407
1408 1408
1409 LInstruction* LChunkBuilder::DoFlooringDivByPowerOf2I(HMathFloorOfDiv* instr) { 1409 LInstruction* LChunkBuilder::DoFlooringDivByPowerOf2I(HMathFloorOfDiv* instr) {
1410 LOperand* dividend = UseRegisterAtStart(instr->left()); 1410 LOperand* dividend = UseRegisterAtStart(instr->left());
1411 int32_t divisor = instr->right()->GetInteger32Constant(); 1411 int32_t divisor = instr->right()->GetInteger32Constant();
1412 LInstruction* result = 1412 LInstruction* result = DefineSameAsFirst(new(zone()) LFlooringDivByPowerOf2I(
1413 DefineSameAsFirst(new(zone()) LFlooringDivByPowerOf2I(dividend, divisor)); 1413 dividend, divisor));
1414 bool can_deopt = 1414 if ((instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) ||
1415 (instr->CheckFlag(HValue::kBailoutOnMinusZero) && divisor < 0) || 1415 (instr->CheckFlag(HValue::kLeftCanBeMinInt) && divisor == -1)) {
1416 (instr->left()->RangeCanInclude(kMinInt) && divisor == -1); 1416 result = AssignEnvironment(result);
1417 return can_deopt ? AssignEnvironment(result) : result; 1417 }
1418 return result;
1418 } 1419 }
1419 1420
1420 1421
1421 LInstruction* LChunkBuilder::DoFlooringDivByConstI(HMathFloorOfDiv* instr) { 1422 LInstruction* LChunkBuilder::DoFlooringDivByConstI(HMathFloorOfDiv* instr) {
1422 ASSERT(instr->representation().IsInteger32()); 1423 ASSERT(instr->representation().IsInteger32());
1423 ASSERT(instr->left()->representation().Equals(instr->representation())); 1424 ASSERT(instr->left()->representation().Equals(instr->representation()));
1424 ASSERT(instr->right()->representation().Equals(instr->representation())); 1425 ASSERT(instr->right()->representation().Equals(instr->representation()));
1425 LOperand* dividend = UseRegister(instr->left()); 1426 LOperand* dividend = UseRegister(instr->left());
1426 int32_t divisor = instr->right()->GetInteger32Constant(); 1427 int32_t divisor = instr->right()->GetInteger32Constant();
1427 LOperand* temp1 = FixedTemp(eax); 1428 LOperand* temp1 = FixedTemp(eax);
(...skipping 1246 matching lines...) Expand 10 before | Expand all | Expand 10 after
2674 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2675 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2675 LOperand* object = UseRegister(instr->object()); 2676 LOperand* object = UseRegister(instr->object());
2676 LOperand* index = UseTempRegister(instr->index()); 2677 LOperand* index = UseTempRegister(instr->index());
2677 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2678 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2678 } 2679 }
2679 2680
2680 2681
2681 } } // namespace v8::internal 2682 } } // namespace v8::internal
2682 2683
2683 #endif // V8_TARGET_ARCH_IA32 2684 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698