Source/core/css/StyleSheetContents.h - Issue 196653006: Optimize StyleSheetContents::checkLoaded by keeping track of completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StyleSheetContents.h

Issue 196653006: Optimize StyleSheetContents::checkLoaded by keeping track of completed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/StyleSheetContents.h

diff --git a/Source/core/css/StyleSheetContents.h b/Source/core/css/StyleSheetContents.h

index be057560e0f0fa2346b157328dccc756a9abc739..8090f8e4b4df48c115f1d95bd2819a51c0266376 100644

--- a/Source/core/css/StyleSheetContents.h

+++ b/Source/core/css/StyleSheetContents.h

@@ -139,7 +139,9 @@ public:

void registerClient(CSSStyleSheet*);

void unregisterClient(CSSStyleSheet*);

- bool hasOneClient() { return m_clients.size() == 1; }

+ bool hasOneClient() { return (m_loadingClients.size() + m_completedClients.size()) == 1; }

+ void clientLoadCompleted(CSSStyleSheet*);

+ void clientLoadStarted(CSSStyleSheet*);

bool isMutable() const { return m_isMutable; }

void setMutable() { m_isMutable = true; }

@@ -185,7 +187,8 @@ private:

CSSParserContext m_parserContext;

- WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSStyleSheet> > m_clients;

+ WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSStyleSheet> > m_loadingClients;

+ WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSStyleSheet> > m_completedClients;

typedef WillBeHeapHashSet<RawPtrWillBeWeakMember<CSSStyleSheet> >::iterator ClientsIterator;

OwnPtrWillBeMember<RuleSet> m_ruleSet;

« no previous file with comments | « Source/core/css/CSSStyleSheet.cpp ('k') | Source/core/css/StyleSheetContents.cpp » ('j') | no next file with comments »