Source/bindings/scripts/code_generator_v8.py - Issue 196653003: Add [DoNotGenerateClassBindings] extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 196653003: Add [DoNotGenerateClassBindings] extended attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Compiles and links Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.py

diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py

index 09a119f0e766a4d3a7d3b6f4d1eddccfc133d6dc..e521d01c16d3f41b8895d55d7bcae5249326e87e 100644

--- a/Source/bindings/scripts/code_generator_v8.py

+++ b/Source/bindings/scripts/code_generator_v8.py

@@ -133,6 +133,9 @@ class CodeGeneratorV8(object):

# Add includes for interface itself and any dependencies

interface_info = self.interfaces_info[interface_name]

template_contents['header_includes'].add(interface_info['include_path'])

+ if not template_contents['has_class_bindings']:

+ template_contents['header_includes'].add(

+ 'V8%s.h' % interface_info['implemented_as'])

template_contents['header_includes'] = sorted(template_contents['header_includes'])

includes.update(interface_info.get('dependencies_include_paths', []))

template_contents['cpp_includes'] = sorted(includes)