Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1966443003: Call SetTranslateEnable(true) in the 2016Q2 UI even it is blocked language or blocked URL so Omniba… (Closed)

Created:
4 years, 7 months ago by ftang
Modified:
4 years, 7 months ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call SetTranslateEnable(true) in the 2016Q2 UI even it is blocked language or blocked URL so Omnibar will display the translate icon BUG=610376 Committed: https://crrev.com/e9194fafbe858338e049ff946d2f844c20f7c944 Cr-Commit-Position: refs/heads/master@{#392550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/translate/core/browser/translate_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966443003/1
4 years, 7 months ago (2016-05-10 00:05:39 UTC) #2
ftang
hajimehoshi@chromium.org Could you review this simple fix?
4 years, 7 months ago (2016-05-10 00:47:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 01:04:56 UTC) #6
hajimehoshi
lgtm
4 years, 7 months ago (2016-05-10 05:24:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966443003/1
4 years, 7 months ago (2016-05-10 05:25:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 05:29:03 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 05:30:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9194fafbe858338e049ff946d2f844c20f7c944
Cr-Commit-Position: refs/heads/master@{#392550}

Powered by Google App Engine
This is Rietveld 408576698