Issue 19664010: Roll Skia DEPS to r10296

This roll is blocked on the BackgroundFilterBlurOutsets cc_unittest failure and
the testColorSpace webkit_unit_test failure. 

Here is some of the text from the BackgroundFilterBlurOutsets failure:

[----------] 1 test from LayerTreeHostFiltersPixelTest
[ RUN      ] LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets
[18473:18473:0723/162925:264570793494:ERROR:pixel_comparator.cc(40)] Pixel error
at x=12 y=12; actual RGBA=(102,179,102,0); expected RGBA=(101,179,101,0)
[18473:18473:0723/162925:264570793577:ERROR:pixel_comparator.cc(40)] Pixel error
at x=12 y=13; actual RGBA=(112,183,112,0); expected RGBA=(111,184,111,0)
[18473:18473:0723/162925:264570793606:ERROR:pixel_comparator.cc(40)] Pixel error
at x=12 y=14; actual RGBA=(122,189,122,0); expected RGBA=(121,188,121,0)
[18473:18473:0723/162925:264570793636:ERROR:pixel_comparator.cc(40)] Pixel error
at x=12 y=15; actual RGBA=(130,192,130,0); expected RGBA=(130,193,130,0)
.
.
.
[18473:18473:0723/162925:264570818143:ERROR:pixel_comparator.cc(40)] Pixel error
at x=186 y=13; actual RGBA=(123,189,123,0); expected RGBA=(123,188,123,0)
[18473:18473:0723/162925:264570818178:ERROR:pixel_comparator.cc(40)] Pixel error
at x=186 y=14; actual RGBA=(135,195,135,0); expected RGBA=(134,194,134,0)
[18473:18473:0723/162925:264570818245:ERROR:pixel_comparator.cc(40)] Pixel error
at x=187 y=12; actual RGBA=(102,179,102,0); expected RGBA=(102,178,102,0)
[18473:18473:0723/162925:264570818281:ERROR:pixel_comparator.cc(40)] Pixel error
at x=187 y=14; actual RGBA=(122,189,122,0); expected RGBA=(122,188,122,0)
[18473:18473:0723/162925:264570818694:ERROR:pixel_comparator.cc(56)] Number of
pixel with an error: 698
../../cc/test/layer_tree_pixel_test.cc:109: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
  Actual: false
Expected: true
[  FAILED  ] LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets (1076 ms)

The text from the testColorSpace failure is:

[----------] 1 test from ImageFilterBuilderTest
[ RUN      ] ImageFilterBuilderTest.testColorSpace
e:\b\build\slave\win_layout\build\src\third_party\webkit\source\web\tests\imagefilterbuildertest.cpp(99):
error: Value of: true
Expected: child->asColorFilter(0)
Which is: false
e:\b\build\slave\win_layout\build\src\third_party\webkit\source\web\tests\imagefilterbuildertest.cpp(105):
error: Value of: true
Expected: child->asColorFilter(0)
Which is: false
e:\b\build\slave\win_layout\build\src\third_party\webkit\source\web\tests\imagefilterbuildertest.cpp(111):
error: Value of: true
Expected: child->asColorFilter(0)
Which is: false
[  FAILED  ] ImageFilterBuilderTest.testColorSpace (0 ms)
[----------] 1 test from ImageFilterBuilderTest (0 ms total)

Here are the discrepancies between the roll and control:

android_rel
   roll:    
            slave_steps preamble
            webkit_unit_tests
                ImageFilterBuilderTest.testColorSpace
   control: 
            green

android_dbg
   roll:    
            slave_steps preamble
            webkit_unit_tests
                ImageFilterBuilderTest.testColorSpace
   control: 
            green

linux
   roll:    
            buildrunner_tests preamble
            cc_unittests 1 disabled failed 1
                BackgroundFilterBlurOutsets
   control: 
            green

linux_asan
   roll:    
            cc_unittests 1 disabled failed 1
                BackgroundFilterBlurOutsets
   control: 
            green

linux
   roll:    
            buildrunner_tests preamble
            cc_unittests 1 disabled failed 1
                BackgroundFilterBlurOutsets
   control: 
            green

linux_asan
   roll:    
            cc_unittests 1 disabled failed 1
                BackgroundFilterBlurOutsets
   control: 
            green

win
   roll:    
            buildrunner_tests preamble
            cc_unittests 1 disabled failed 1
                BackgroundFilterBlurOutsets *************************
            views_unittests 8 disabled failed 1
                CaptureWidgetFromMousePress
            webkit_unit_tests 15 disabled failed 1
                testColorSpace **************************************
   control: 
            buildrunner_tests preamble
            views_unittests 8 disabled failed 1
                CaptureWidgetFromMousePress
            nacl_integration

win_gpu
   roll:    
            gl_tests 1 disabled failed 1
                RenderTo
            content_browsertests failed 116
                MANUAL*
   control: 
            gl_tests 1 disabled failed 1
                RenderTo
            content_browsertests failed 112
                MANUAL*

linux_layout
   roll:    
            buildrunner_tests preamble
            webkit_unit_tests 13 disabled failed 1
                testColorSpace
   control: 
            green

linux_layout_rel
   roll:    
             buildrunner_tests preamble
             webkit_unit_tests 13 disabled failed 1
                 testColorSpace
   control: 
            green

mac_layout
   roll:    
            buildrunner_tests preamble
            webkit_unit_tests 14 disabled failed 1
                testColorSpace
   control: 
            buildrunner_tests preamble
            webkit_unit_tests did not complete failed 1
                Sanity

mac_layout_rel
   roll:    
            buildrunner_tests preamble
            webkit_unit_tests 14 disabled failed 1
                testColorSpace
   control: 
            green

win_layout
   roll:    
            webkit_tests 1552 fixable (0 skipped) failed 1
                canvas-fillPath-pattern-shadow.html *****************
            buildrunner_tests preamble
            webkit_unit_tests 15 disabled failed 1
                testColorSpace **************************************
   control: 
            webkit_tests 1542 fixable (0 skipped) failed 2
                css-selector-text.html
                transition-end-event-set-none.html

win_layout_rel
   roll:    
            webkit_tests 1400 fixable (0 skipped) failed 2
                appcache-swap.html
                online-whitelist.html
            buildrunner_tests preamble
            webkit_unit_tests 15 disabled failed 1
                testColorSpace
   control: 
            green

senorblanco

7 years, 5 months ago (2013-07-24 17:24:14 UTC) #4

On Wed, Jul 24, 2013 at 8:25 AM, <tomhudson@google.com> wrote:

> Looks like the cc_unittest needs a rebaseline?
>
>
https://codereview.chromium.**org/19664010/<https://codereview.chromium.org/1...
>

The first test can be rebaselined along with the roll, but the other
failure (ImageFilterBuilderTest.**testColorSpace) looks like an actual bug.
I've asked Robert to revert r10251 for now (done in r10304).

Stephen

Expand Messages | Collapse Messages