Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 196633009: Use CheckedNumerics in AsyncPixelTransfersCompletedQuery, add tests (Closed)

Created:
6 years, 9 months ago by piman
Modified:
6 years, 9 months ago
Reviewers:
jschuh, jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Use CheckedNumerics in AsyncPixelTransfersCompletedQuery, add tests This is a follow-up to https://codereview.chromium.org/198253002/ 1- It converts the code to use CheckedNumerics 2- It adds unit tests: * converts existing tests to exercise all query types * adds an additional test to exercise overflow explicitly 3- Fixes a minor issue with GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM, where out-of-bounds access would be silently failing instead of losing the context. BUG=351852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256918

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -62 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 2 chunks +81 lines, -50 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
(this was separated out for easier merging of the previous CL)
6 years, 9 months ago (2014-03-13 00:22:48 UTC) #1
jschuh
lgtm on the security side
6 years, 9 months ago (2014-03-13 01:57:11 UTC) #2
jbauman
lgtm
6 years, 9 months ago (2014-03-13 02:45:14 UTC) #3
piman
The CQ bit was checked by piman@chromium.org
6 years, 9 months ago (2014-03-13 04:48:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/196633009/10001
6 years, 9 months ago (2014-03-13 04:48:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 05:41:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 9 months ago (2014-03-13 05:41:41 UTC) #7
piman
The CQ bit was checked by piman@chromium.org
6 years, 9 months ago (2014-03-13 18:12:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/196633009/20001
6 years, 9 months ago (2014-03-13 18:15:06 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 20:35:28 UTC) #10
Message was sent while issue was closed.
Change committed as 256918

Powered by Google App Engine
This is Rietveld 408576698