core/fxcrt/include/fx_string.h - Issue 1966293002: Use bytestringC rather than raw ptr/len pairs in syntax parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/include/fx_string.h

Issue 1966293002: Use bytestringC rather than raw ptr/len pairs in syntax parser (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add comment to fx_string.h Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/fxcrt/include/fx_string.h

diff --git a/core/fxcrt/include/fx_string.h b/core/fxcrt/include/fx_string.h

index 10a70d9334b268cfb197b96894e306a9386d8157..66a8039a8d43db70c589cf7ae464e22792a0cd6c 100644

--- a/core/fxcrt/include/fx_string.h

+++ b/core/fxcrt/include/fx_string.h

@@ -19,7 +19,8 @@ class CFX_ByteString;

class CFX_WideString;

// An immutable string with caller-provided storage which must outlive the

-// string itself.

+// string itself. These are not necessarily nul-terminated, so that substring

+// extraction (via the Mid() method) is copy-free.

class CFX_ByteStringC {

public:

typedef FX_CHAR value_type;

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp ('k') | no next file » | no next file with comments »