Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: extensions/renderer/messaging_bindings.h

Issue 1966283002: Remove port lifetime management from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use MakeUnique instead of WrapUnique Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/extension_frame_helper.cc ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/messaging_bindings.h
diff --git a/extensions/renderer/messaging_bindings.h b/extensions/renderer/messaging_bindings.h
index a7a1c6fef80704a7449403763e32ddfd9f409d7f..4c52c631ce0eb8125ea354e60095f9d9382a15dc 100644
--- a/extensions/renderer/messaging_bindings.h
+++ b/extensions/renderer/messaging_bindings.h
@@ -25,7 +25,6 @@ class Extension;
}
namespace extensions {
-class Dispatcher;
struct Message;
class ObjectBackedNativeHandler;
class ScriptContextSet;
@@ -38,8 +37,13 @@ class ScriptContextSet;
class MessagingBindings {
public:
// Creates an instance of the extension.
- static ObjectBackedNativeHandler* Get(Dispatcher* dispatcher,
- ScriptContext* context);
+ static ObjectBackedNativeHandler* Get(ScriptContext* context);
+
+ // Checks whether the port exists in the given frame. If it does not, a reply
+ // is sent back to the browser.
+ static void ValidateMessagePort(const ScriptContextSet& context_set,
+ int port_id,
+ content::RenderFrame* render_frame);
// Dispatches the onConnect content script messaging event to some contexts
// in |context_set|. If |restrict_to_render_frame| is specified, only contexts
« no previous file with comments | « extensions/renderer/extension_frame_helper.cc ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698