Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5665)

Unified Diff: chrome/browser/extensions/api/messaging/message_service.cc

Issue 1966283002: Remove port lifetime management from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin's nits up to #12 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/message_service.cc
diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc
index 507b7ef577811fe2191480d303d040d737578af8..b400e385f4eab31088a69ae0df03ff6b6480c64d 100644
--- a/chrome/browser/extensions/api/messaging/message_service.cc
+++ b/chrome/browser/extensions/api/messaging/message_service.cc
@@ -569,13 +569,14 @@ void MessageService::OpenChannelImpl(BrowserContext* browser_context,
return;
}
- std::unique_ptr<MessagePort> opener(
+ std::unique_ptr<ExtensionMessagePort> opener(
new ExtensionMessagePort(weak_factory_.GetWeakPtr(),
GET_OPPOSITE_PORT_ID(params->receiver_port_id),
params->source_extension_id, source, false));
if (!opener->IsValidPort())
return;
opener->OpenPort(params->source_process_id, params->source_routing_id);
+ opener->RevalidatePort();
params->receiver->RemoveCommonFrames(*opener);
if (!params->receiver->IsValidPort()) {

Powered by Google App Engine
This is Rietveld 408576698