Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1966263002: PPC: [Interpreter] Fix incorrect frame walking in arguments create stubs (Closed)

Created:
4 years, 7 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Fix incorrect frame walking in arguments create stubs Port 40f345416f00761c79b9d2094c2e12e798329935 Original commit message: The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub looked at the function slot in order to skip stub frames and find the JS frame. However, stub frames do not have a function slot (in fact their fixed frame ends one slot before the JS frame's function slot). Therefore, if this location in the stub frame happens to have the function object the create arguments stubs won't skip this frame correctly. Replace this approach with one where the stub is specialized to either skip a frame if required (since there will only ever be one extra frame on Ignition the loop approach isn't necessary). R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4928 LOG=N Committed: https://crrev.com/adcc5119867922cc04859a6fd8ea8644bac5bde6 Cr-Commit-Position: refs/heads/master@{#36186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M src/ppc/code-stubs-ppc.cc View 3 chunks +33 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 7 months ago (2016-05-11 17:04:07 UTC) #1
MTBrandyberry
lgtm
4 years, 7 months ago (2016-05-11 17:15:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966263002/1
4 years, 7 months ago (2016-05-11 17:17:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 17:38:16 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 17:38:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adcc5119867922cc04859a6fd8ea8644bac5bde6
Cr-Commit-Position: refs/heads/master@{#36186}

Powered by Google App Engine
This is Rietveld 408576698