Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1966243002: Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium. (Closed)

Created:
4 years, 7 months ago by mmoss
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966743002/ ) Reason for revert: Using "recursedeps" broke buildspec creation. Original issue's description: > Pin dEQP DEPS to ANGLE's DEPS.chromium. > > This file will manage which dEQP revision Chrome checks out. This > allows ANGLE to roll dEQP in the same CL as it updates the build > files, which makes testing on the bots possible. > > BUG=605987 > R=iannucci@chromium.org > > Committed: https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806 > Cr-Commit-Position: refs/heads/master@{#392697} TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,jmadill@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605987 Committed: https://crrev.com/b627a76883d422736db77ef71fafe26d7f3b3812 Cr-Commit-Position: refs/heads/master@{#392930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M DEPS View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mmoss
Created Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium.
4 years, 7 months ago (2016-05-11 15:26:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966243002/1
4 years, 7 months ago (2016-05-11 15:26:31 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-11 15:26:33 UTC) #4
Michael Moss
On 2016/05/11 15:26:33, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 7 months ago (2016-05-11 15:32:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966243002/1
4 years, 7 months ago (2016-05-11 15:32:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 15:33:12 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b627a76883d422736db77ef71fafe26d7f3b3812 Cr-Commit-Position: refs/heads/master@{#392930}
4 years, 7 months ago (2016-05-11 15:34:51 UTC) #10
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-11 16:08:33 UTC) #11
Jamie Madill
4 years, 6 months ago (2016-06-16 14:39:25 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2066993006/ by jmadill@chromium.org.

The reason for reverting is: buildspec creation should be now fixed..

Powered by Google App Engine
This is Rietveld 408576698