Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1966233002: Removed generic method tests from status file. (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed generic method tests from status file. CL https://codereview.chromium.org/1969753002/ which was just landed did not contain one correction: Some generic method related tests used to cause an internal error in dart2js with --enable-checked-mode, but 1969753002 fixed that. This CL just removes those tests from the status file. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/fa48b7e17ba79038c465270f40d2b6caa9cae954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eernst
The civilized way to do this would be to revert CL 1969753002, but the problem ...
4 years, 7 months ago (2016-05-11 13:17:32 UTC) #2
Johnni Winther
lgtm
4 years, 7 months ago (2016-05-11 13:20:33 UTC) #3
eernst
4 years, 7 months ago (2016-05-11 13:33:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa48b7e17ba79038c465270f40d2b6caa9cae954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698