Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1966223002: Helper for interesting things to do when a block becomes a float or out-of-flow. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Helper for interesting things to do when a block becomes a float or out-of-flow. Also added some requirements for the blocks involved to be LayoutBlockFlow. We don't want to touch anything else. BUG=302024 Committed: https://crrev.com/186ff070c39eeaa99f51fa986ab1a4c383e263ac Cr-Commit-Position: refs/heads/master@{#393121}

Patch Set 1 #

Patch Set 2 : fixup! Helper for interesting things to do when a block becomes a float or out-of-flow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-11 21:35:37 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-11 22:07:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966223002/20001
4 years, 7 months ago (2016-05-11 22:08:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 00:32:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 00:37:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/186ff070c39eeaa99f51fa986ab1a4c383e263ac
Cr-Commit-Position: refs/heads/master@{#393121}

Powered by Google App Engine
This is Rietveld 408576698