Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1966203002: Use the NTP-MD flag for transparent doodle requests. (Closed)

Created:
4 years, 7 months ago by atanasova
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Marc Treib, tschumann
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the NTP-MD flag for transparent doodle requests. Instead of creating a new flag, start using the NTP-MD flag when deciding whether to request a transparent doodle. This requires some clean up of the previously created flag. BUG=610319 Committed: https://crrev.com/be7524009dee61560b43c3f5445025bf5818d0e4 Cr-Commit-Position: refs/heads/master@{#392929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/logo_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
atanasova
4 years, 7 months ago (2016-05-11 11:47:20 UTC) #2
Marc Treib
lgtm
4 years, 7 months ago (2016-05-11 11:59:50 UTC) #4
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-11 14:31:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966203002/1
4 years, 7 months ago (2016-05-11 14:35:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 15:29:16 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 15:31:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be7524009dee61560b43c3f5445025bf5818d0e4
Cr-Commit-Position: refs/heads/master@{#392929}

Powered by Google App Engine
This is Rietveld 408576698