Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: runtime/vm/dart_entry_test.cc

Issue 19662003: Refactor resolution code in the vm to properly handle ambiguity errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry_test.cc
===================================================================
--- runtime/vm/dart_entry_test.cc (revision 25321)
+++ runtime/vm/dart_entry_test.cc (working copy)
@@ -27,9 +27,10 @@
Library& lib = Library::Handle(Library::CoreLibrary());
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
+ String& ambiguity_error_msg = String::Handle();
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(Symbols::New("A"))));
- EXPECT(!cls.IsNull());
+ lib.LookupClass(String::Handle(Symbols::New("A")), &ambiguity_error_msg));
+ EXPECT(!cls.IsNull()); // No ambiguity error expected.
String& name = String::Handle(String::New("foo"));
Function& function = Function::Handle(cls.LookupStaticFunction(name));
EXPECT(!function.IsNull());
@@ -55,9 +56,10 @@
Library& lib = Library::Handle(Library::CoreLibrary());
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
+ String& ambiguity_error_msg = String::Handle();
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(Symbols::New("A"))));
- EXPECT(!cls.IsNull());
+ lib.LookupClass(String::Handle(Symbols::New("A")), &ambiguity_error_msg));
+ EXPECT(!cls.IsNull()); // No ambiguity error expected.
String& name = String::Handle(String::New("foo"));
Function& function = Function::Handle(cls.LookupStaticFunction(name));
EXPECT(!function.IsNull());
@@ -82,9 +84,10 @@
Library& lib = Library::Handle(Library::CoreLibrary());
EXPECT_EQ(true, CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
+ String& ambiguity_error_msg = String::Handle();
Class& cls = Class::Handle(
- lib.LookupClass(String::Handle(Symbols::New("A"))));
- EXPECT(!cls.IsNull());
+ lib.LookupClass(String::Handle(Symbols::New("A")), &ambiguity_error_msg));
+ EXPECT(!cls.IsNull()); // No ambiguity error expected.
// Invoke the constructor.
const Instance& instance = Instance::Handle(Instance::New(cls));
« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698