Refactor resolution code in the vm to properly handle ambiguity errors.

runtime/vm/cha_test.cc

Index: runtime/vm/cha_test.cc
===================================================================
--- runtime/vm/cha_test.cc	(revision 25291)
+++ runtime/vm/cha_test.cc	(working copy)
@@ -34,22 +34,22 @@
   EXPECT(!lib.IsNull());
 
   const Class& class_a = Class::Handle(
-      lib.LookupClass(String::Handle(Symbols::New("A"))));
+      lib.LookupClass(String::Handle(Symbols::New("A")), NULL));
   EXPECT(!class_a.IsNull());

[siva, 2013/07/22 22:21:46]

This is a case where if we have some bugs the test instead of
failing will crash. I wonder if it is better to pass in a non
NULL value here.

[regis, 2013/07/22 23:51:27]

Done.

   const intptr_t class_a_id = class_a.id();
 
   const Class& class_b = Class::Handle(
-      lib.LookupClass(String::Handle(Symbols::New("B"))));
+      lib.LookupClass(String::Handle(Symbols::New("B")), NULL));
   EXPECT(!class_b.IsNull());
   const intptr_t class_b_id = class_b.id();
 
   const Class& class_c = Class::Handle(
-      lib.LookupClass(String::Handle(Symbols::New("C"))));
+      lib.LookupClass(String::Handle(Symbols::New("C")), NULL));
   EXPECT(!class_c.IsNull());
   const intptr_t class_c_id = class_c.id();
 
   const Class& class_d = Class::Handle(
-      lib.LookupClass(String::Handle(Symbols::New("D"))));
+      lib.LookupClass(String::Handle(Symbols::New("D")), NULL));
   EXPECT(!class_d.IsNull());
   const intptr_t class_d_id = class_d.id();