Refactor resolution code in the vm to properly handle ambiguity errors.

runtime/vm/class_finalizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 243 matching lines @@
 }
 
 
 // Resolve unresolved_class in the library of cls, or return null.
 RawClass* ClassFinalizer::ResolveClass(const Class& cls,
                                        const UnresolvedClass& unresolved_class,
                                        Error* ambiguity_error) {
   const String& class_name = String::Handle(unresolved_class.ident());
   Library& lib = Library::Handle();
   Class& resolved_class = Class::Handle();
+  String& ambiguity_error_msg = String::Handle();
   if (unresolved_class.library_prefix() == LibraryPrefix::null()) {
     lib = cls.library();
     ASSERT(!lib.IsNull());
-    // TODO(regis): Call lib.LookupClass(class_name, ambiguity_error) instead
-    // once it takes the ambiguity_error parameter.
-
-    // First check if name is found in the local scope of the library.
-    Object& obj = Object::Handle(lib.LookupLocalObject(class_name));
-    if (!obj.IsNull() && obj.IsClass()) {
-      return Class::Cast(obj).raw();
-    }
-    // Now check if class_name is found in any imported libs.
-    String& first_lib_url = String::Handle();
-    Namespace& import = Namespace::Handle();
-    Library& import_lib = Library::Handle();
-    for (intptr_t i = 0; i < lib.num_imports(); i++) {
-      import ^= lib.ImportAt(i);
-      obj = import.Lookup(class_name);
-      if (!obj.IsNull()) {
-        import_lib = import.library();
-        if (!first_lib_url.IsNull()) {
-          // Found duplicate definition.
-          const Script& script = Script::Handle(cls.script());
-          if (first_lib_url.raw() == lib.url()) {
-            *ambiguity_error = Parser::FormatErrorMsg(
-                script, unresolved_class.token_pos(), "Error",
-                "ambiguous reference to '%s', "
-                "as library '%s' is imported multiple times",
-                class_name.ToCString(),
-                first_lib_url.ToCString());
-          } else {
-            *ambiguity_error = Parser::FormatErrorMsg(
-                script, unresolved_class.token_pos(), "Error",
-                "ambiguous reference: "
-                "'%s' is defined in library '%s' and also in '%s'",
-                class_name.ToCString(),
-                first_lib_url.ToCString(),
-                String::Handle(lib.url()).ToCString());
-          }
-          return Class::null();
-        }
-        first_lib_url = lib.url();
-        if (obj.IsClass()) {
-          resolved_class = Class::Cast(obj).raw();
-        }
-      }
-    }
+    resolved_class = lib.LookupClass(class_name, &ambiguity_error_msg);
   } else {
     LibraryPrefix& lib_prefix = LibraryPrefix::Handle();
     lib_prefix = unresolved_class.library_prefix();
     ASSERT(!lib_prefix.IsNull());
-    resolved_class = lib_prefix.LookupLocalClass(class_name);
+    resolved_class = lib_prefix.LookupClass(class_name, &ambiguity_error_msg);
+  }
+  if (resolved_class.IsNull() && !ambiguity_error_msg.IsNull()) {
+    const Script& script = Script::Handle(cls.script());
+    *ambiguity_error = Parser::FormatErrorMsg(
+        script, unresolved_class.token_pos(), "Error",
+        "%s", ambiguity_error_msg.ToCString());
   }
   return resolved_class.raw();
 }
 
 
 void ClassFinalizer::ResolveRedirectingFactoryTarget(
     const Class& cls,
     const Function& factory,
     const GrowableObjectArray& visited_factories) {
   ASSERT(factory.IsRedirectingFactory());
@@ skipping 1879 matching lines @@
   expected_name ^= String::New("_offset");
   ASSERT(String::EqualsIgnoringPrivateKey(name, expected_name));
   field ^= fields_array.At(2);
   ASSERT(field.Offset() == TypedDataView::length_offset());
   name ^= field.name();
   ASSERT(name.Equals("length"));
 #endif
 }
 
 }  // namespace dart