Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1966193002: Add script injection when replaying with callstats.py (Closed)

Created:
4 years, 7 months ago by nickie
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add script injection when replaying with callstats.py This allows benchmarking without --single-process and correctly gathering --runtime-call-stats numbers. Add optional parameter to %GetAndResetRuntimeCallStats - Without any parameter, it returns a string with the runtime call statistics (as before). - With one string parameter, it appends the statistics to the file with that file name. - With one integer parameter (which must be 1=stdout or 2=stderr), it prints the statistics to the output with of that file descriptor. The injected script is automatically generated. Also, callstats.py does not have a hardwired DEFAULT_SITES anymore. R=cbruni@chromium.org BUG= LOG=N Committed: https://crrev.com/5fa1c61ee0babe9e4c3b2fa0069912e6d42ee2dc Cr-Commit-Position: refs/heads/master@{#36172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -66 lines) Patch
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +35 lines, -7 lines 0 comments Download
M tools/callstats.py View 12 chunks +72 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nickie
4 years, 7 months ago (2016-05-11 11:42:52 UTC) #1
nickie
For injection to work properly for sites with strict content security policy (like twitter.com), see: ...
4 years, 7 months ago (2016-05-11 11:45:59 UTC) #2
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-11 11:50:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966193002/1
4 years, 7 months ago (2016-05-11 11:51:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 12:23:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:24:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fa1c61ee0babe9e4c3b2fa0069912e6d42ee2dc
Cr-Commit-Position: refs/heads/master@{#36172}

Powered by Google App Engine
This is Rietveld 408576698