Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1966183002: Always check that a Name is a String before converting it. (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Always check that a Name is a String before converting it. BUG=608662 R=haraken@chromium.org Review-Url: https://codereview.chromium.org/1967453002 Cr-Commit-Position: refs/heads/master@{#392567} (cherry picked from commit 544ea1e08ba0f678208e3c468aa576358ab542fb) Committed: https://chromium.googlesource.com/chromium/src/+/3feb071cc34b00e29a2a3e96b7766777d23d1703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 5 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-11 11:02:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3feb071cc34b00e29a2a3e96b7766777d23d1703.

Powered by Google App Engine
This is Rietveld 408576698