Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 1966173003: Revert of Implement CPU time for OS X and POSIX. (Closed)

Created:
4 years, 7 months ago by lpy
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement CPU time for OS X and POSIX. (patchset #10 id:180001 of https://codereview.chromium.org/1959103004/ ) Reason for revert: Buildbot is failing on Mac release build. Original issue's description: > Implement CPU time for OS X and POSIX. > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > implements CPU time for OS X and POSIX to provide more accurate > accounting of CPU time used by each thread. > > BUG=v8:4984 > LOG=n > > Committed: https://crrev.com/025f3d262bab2748362374f1b90ac723a9655ee4 > Cr-Commit-Position: refs/heads/master@{#36188} TBR=jochen@chromium.org,bmeurer@chromium.org,fmeawad@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Committed: https://crrev.com/bfb1c9e63cb03e1666cfde09811164db2a627a56 Cr-Commit-Position: refs/heads/master@{#36189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -127 lines) Patch
M src/base/platform/time.h View 2 chunks +1 line, -26 lines 0 comments Download
M src/base/platform/time.cc View 4 chunks +6 lines, -73 lines 0 comments Download
M test/unittests/base/platform/time-unittest.cc View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
lpy
Created Revert of Implement CPU time for OS X and POSIX.
4 years, 7 months ago (2016-05-11 21:09:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966173003/1
4 years, 7 months ago (2016-05-11 21:09:23 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-11 21:09:26 UTC) #4
fmeawad
lgtm
4 years, 7 months ago (2016-05-11 21:11:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966173003/1
4 years, 7 months ago (2016-05-11 21:11:12 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-11 21:11:14 UTC) #9
adamk
lgtm
4 years, 7 months ago (2016-05-11 21:15:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966173003/1
4 years, 7 months ago (2016-05-11 21:16:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 21:16:15 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 21:17:50 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfb1c9e63cb03e1666cfde09811164db2a627a56
Cr-Commit-Position: refs/heads/master@{#36189}

Powered by Google App Engine
This is Rietveld 408576698