Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1966123002: libgtk2ui: Add missing //ui/display dependency (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
oshima, Evan Stade
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libgtk2ui: Add missing //ui/display dependency It's currently missing, causing build flakes in the waterfall such as gtk2_ui.cc: undefined reference to 'display::Display::HasForceDeviceScaleFactor() in https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/52888 BUG=597761 TBR=estade@chromium.org NOTREECHEKS=true Committed: https://crrev.com/9f509e847006d97546d92b28b229c66771c49d84 Cr-Commit-Position: refs/heads/master@{#392854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
oshima
lgtm
4 years, 7 months ago (2016-05-11 03:48:56 UTC) #1
tapted
thanks oshima! +estade TBR for owners (TBR to fix build breakage)
4 years, 7 months ago (2016-05-11 03:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1966123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1966123002/1
4 years, 7 months ago (2016-05-11 03:51:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 04:51:35 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f509e847006d97546d92b28b229c66771c49d84 Cr-Commit-Position: refs/heads/master@{#392854}
4 years, 7 months ago (2016-05-11 04:53:12 UTC) #10
Evan Stade
4 years, 7 months ago (2016-05-12 00:51:27 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698