Issue 19661006: Revert last week's OrderIterator changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19661006: Revert last week's OrderIterator changes (Closed)

Created:
7 years, 5 months ago by Julien - ping for review

Modified:
7 years, 5 months ago

Reviewers:
cbiesinger, ojan

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Revert last week's OrderIterator changes The original change (https://chromiumcodereview.appspot.com/18162016) has created several regressions and it seems that the approach could be improved so reverting for now to dig deeper. TBR=ojan@chromium.org,cbiesinger@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154693

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -77 lines)			Patch
M	Source/core/rendering/OrderIterator.h	View	3 chunks	+10 lines, -24 lines	0 comments	Download
M	Source/core/rendering/OrderIterator.cpp	View	2 chunks	+47 lines, -35 lines	0 comments	Download
M	Source/core/rendering/RenderFlexibleBox.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderFlexibleBox.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/rendering/RenderGrid.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderGrid.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)

Julien - ping for review

7 years, 5 months ago (2013-07-22 23:30:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r154693 (presubmit successful).