Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: src/virtual-frame-ia32.cc

Issue 19661: Remove the unused, inaptly-named, and incorrect RequiresMergeCode. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/virtual-frame-ia32.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/virtual-frame-ia32.cc
===================================================================
--- src/virtual-frame-ia32.cc (revision 1182)
+++ src/virtual-frame-ia32.cc (working copy)
@@ -273,35 +273,6 @@
}
-bool VirtualFrame::RequiresMergeCode() {
- // A frame requires code to be generated to make the frame mergable if
- // there are duplicated non-synched registers or else valid elements not
- // in a (memory or register) location in the frame. We look for valid
- // non-synced non-location elements and count occurrences of non-synced
- // registers.
- RegisterFile non_synced_regs;
- for (int i = 0; i < elements_.length(); i++) {
- FrameElement element = elements_[i];
- if (element.is_valid() && !element.is_synced()) {
- if (element.is_register()) {
- non_synced_regs.Use(elements_[i].reg());
- } else if (!element.is_memory()) {
- // Not memory or register and not synced.
- return true;
- }
- }
- }
-
- for (int i = 0; i < RegisterFile::kNumRegisters; i++) {
- if (non_synced_regs.count(i) > 1) {
- return true;
- }
- }
-
- return false;
-}
-
-
void VirtualFrame::MakeMergable() {
Comment cmnt(masm_, "[ Make frame mergable");
// We should always be merging the code generator's current frame to an
« no previous file with comments | « src/virtual-frame-ia32.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698