ImageCapture: takePhoto() mock LayoutTest

ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333
Committed: https://crrev.com/b1ac16005aa53c3ceecd666a892371834074d83b
Cr-Commit-Position: refs/heads/master@{#393290}

[mcasas, 2016-05-11 01:28:40]

Description was changed from

==========
ImageCapture: takePhoto() mock LayoutTest

BUG=610333
==========

to

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

BUG=610333
==========

[mcasas, 2016-05-11 01:28:51]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-05-11 05:17:40]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-05-11 05:18:13]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-05-11 05:23:49]

Description was changed from

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

BUG=610333
==========

to

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333
==========

[mcasas, 2016-05-11 05:28:02]

mcasas@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mcasas, 2016-05-11 05:28:03]

mlamouri@ PTAL

[mcasas, 2016-05-11 05:31:47]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2016-05-11 05:31:48]

reillyg@ PTAL as well 

(I see mlamouri@ has loads of reviews)

[mlamouri (slow - plz ping), 2016-05-11 10:21:37]

Is there any reason why you no longer use testharness?

[mcasas, 2016-05-11 15:57:52]

On 2016/05/11 10:21:37, Mounir Lamouri wrote:
> Is there any reason why you no longer use testharness?

All other tests with a mojo mock are not fast/
versions, but compose their own html pages
themselves, so i followed the tradition. WDYT?

[mlamouri (slow - plz ping), 2016-05-11 16:07:48]

On 2016/05/11 at 15:57:52, mcasas wrote:
> On 2016/05/11 10:21:37, Mounir Lamouri wrote:
> > Is there any reason why you no longer use testharness?
> 
> All other tests with a mojo mock are not fast/
> versions, but compose their own html pages
> themselves, so i followed the tradition. WDYT?

testharness.js doesn't have to do with fast/. I would strongly recommend using
this unless you need the old system.

[mcasas, 2016-05-11 16:25:51]

Done changing, PTAL at PS2.

[mcasas, 2016-05-11 17:23:21]

Patchset #2 (id:80001) has been deleted

[mlamouri (slow - plz ping), 2016-05-12 13:19:32]

lgtm. Thanks! :)

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/imagecapture/takephoto.html (right):

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:4: </body>
I would recommend having this after the scripts. It is easy to miss otherwise.

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:15: var test =
async_test(function() {
You don't need |test|, right?

You can do:
`async_test(function(t) {`
if you want to have a reference to the test object.

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:29: this.done();
I would recommend using `t`, this is how it is usually done.

[mcasas, 2016-05-12 16:32:01]

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/imagecapture/takephoto.html (right):

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:4: </body>
On 2016/05/12 13:19:32, Mounir Lamouri wrote:
> I would recommend having this after the scripts. It is easy to miss otherwise.

Done.

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:15: var test =
async_test(function() {
On 2016/05/12 13:19:32, Mounir Lamouri wrote:
> You don't need |test|, right?
> 
> You can do:
> `async_test(function(t) {`
> if you want to have a reference to the test object.

Done.

https://codereview.chromium.org/1966083003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/imagecapture/takephoto.html:29: this.done();
On 2016/05/12 13:19:32, Mounir Lamouri wrote:
> I would recommend using `t`, this is how it is usually done.

Done.

[mcasas, 2016-05-12 16:32:10]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-05-12 16:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1966083003/#ps140001
(title: "mlamouri@ comments")

[commit-bot: I haz the power, 2016-05-12 16:32:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966083003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966083003/140001

[commit-bot: I haz the power, 2016-05-12 17:36:18]

Description was changed from

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333
==========

to

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333
==========

[commit-bot: I haz the power, 2016-05-12 17:36:19]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-05-12 17:38:20]

Description was changed from

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333
==========

to

==========
ImageCapture: takePhoto() mock LayoutTest

ImageCapture takePhoto() implementation needs a
meaningful MediaStream implementation in Browser
side, but LayoutTests doesn't have it. Following the
example of USB, 'battery-status' and 'payments'
Layout Tests, this CL:
- creates a LayoutTest entry for image capture
- defines a MockImageCapture js class, that simply
resolves successfully the takePhoto() Promise
- adds a JS test that instantiates said Mock and
exercises it.

The previous LayoutTest/fast/imagecapture/...takePhoto
is removed.

BUG=610333

Committed: https://crrev.com/b1ac16005aa53c3ceecd666a892371834074d83b
Cr-Commit-Position: refs/heads/master@{#393290}
==========

[commit-bot: I haz the power, 2016-05-12 17:38:22]

Patchset 4 (id:??) landed as
https://crrev.com/b1ac16005aa53c3ceecd666a892371834074d83b
Cr-Commit-Position: refs/heads/master@{#393290}