Issue 196603004: Handle flooring division in LCodeGen::DoDivByConstI on ARM, too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196603004: Handle flooring division in LCodeGen::DoDivByConstI on ARM, too. (Closed)

Created:
6 years, 9 months ago by Sven Panne

Modified:
6 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle flooring division in LCodeGen::DoDivByConstI on ARM, too. We should really split up the Lithium instruction, but this will be done in some future cleanup CL. Removed some "const"s for local variables on the way, they don't really help us much and just clutter up the code. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19850

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -20 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View	1	3 chunks	+21 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 9 months ago (2014-03-12 14:06:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r19850 (presubmit successful).

Expand Messages | Collapse Messages