Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1965983002: Instruct yasm to compile position independent code on Android (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
Reviewers:
Brian Osman, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gyp/libjpeg-turbo.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarett
We could probably pass this flag everywhere, but Android is the client that requires it...
4 years, 7 months ago (2016-05-10 20:35:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965983002/1
4 years, 7 months ago (2016-05-10 20:36:11 UTC) #5
Brian Osman
lgtm
4 years, 7 months ago (2016-05-10 20:39:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-10 21:05:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965983002/1
4 years, 7 months ago (2016-05-10 21:29:13 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 21:30:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fd0b33dee682ac7def48c414533561dff4336d2b

Powered by Google App Engine
This is Rietveld 408576698