Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1965963003: Use new API to download blobs from Google Drive. (Closed)

Created:
4 years, 7 months ago by fukino
Modified:
4 years, 7 months ago
Reviewers:
tzik, kinaba
CC:
tzik, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, kinuko+fileapi, nhiroki, oshima+watch_chromium.org, rginda+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new API to download blobs from Google Drive. The URL to download them is changed from https://www.googledrive.com/p/host/{resourceId} to https://www.googleapis.com/drive/v2/files/{resourceId}?alt=media BUG=496969 TEST=run google_apis_unittests Committed: https://crrev.com/5ef444b6aeb53d691434c4f39e9188a6dcc2a396 Cr-Commit-Position: refs/heads/master@{#393206}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M chrome/browser/apps/drive/drive_service_bridge.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/drive/service/drive_api_service.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/drive/service/drive_api_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/drive/service/drive_api_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 5 chunks +10 lines, -7 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.cc View 4 chunks +2 lines, -11 lines 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/drive/files_list_request_runner_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
fukino
PTAL
4 years, 7 months ago (2016-05-11 15:32:23 UTC) #3
kinaba
lgtm
4 years, 7 months ago (2016-05-11 15:43:24 UTC) #4
fukino
On 2016/05/11 15:43:24, kinaba wrote: > lgtm Thank you for a quick review!
4 years, 7 months ago (2016-05-12 00:02:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965963003/20001
4 years, 7 months ago (2016-05-12 00:03:11 UTC) #7
kinaba
On 2016/05/12 00:03:11, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-12 00:06:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/181738)
4 years, 7 months ago (2016-05-12 00:12:11 UTC) #10
fukino
tzik@, could you take a look at chrome/browser/sync_file_system/ ?
4 years, 7 months ago (2016-05-12 00:21:39 UTC) #12
tzik
lgtm
4 years, 7 months ago (2016-05-12 08:12:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965963003/20001
4 years, 7 months ago (2016-05-12 08:13:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 08:17:02 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 08:18:31 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ef444b6aeb53d691434c4f39e9188a6dcc2a396
Cr-Commit-Position: refs/heads/master@{#393206}

Powered by Google App Engine
This is Rietveld 408576698