Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965943002: Record detailed breakdown of Reader Mode triggering (Closed)

Created:
4 years, 7 months ago by wychen
Modified:
4 years, 7 months ago
Reviewers:
mdjones, jwd
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, asvitkine+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record detailed breakdown of Reader Mode triggering BUG=610794 Committed: https://crrev.com/bec86bbd24ae14ff54c99bfed50a3a0206a59cad Cr-Commit-Position: refs/heads/master@{#393138}

Patch Set 1 #

Patch Set 2 : add passed bucket #

Total comments: 2

Patch Set 3 : naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M components/dom_distiller/content/renderer/distillability_agent.cc View 1 2 2 chunks +25 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
wychen
PTAL
4 years, 7 months ago (2016-05-10 19:49:32 UTC) #2
wychen
jwd@, could you take a look at the histogram? Thanks!
4 years, 7 months ago (2016-05-10 19:50:38 UTC) #4
jwd
https://codereview.chromium.org/1965943002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1965943002/diff/20001/tools/metrics/histograms/histograms.xml#newcode66790 tools/metrics/histograms/histograms.xml:66790: + <int value="4" label="Passed"/> This label seems a bit ...
4 years, 7 months ago (2016-05-11 15:27:20 UTC) #5
wychen
https://codereview.chromium.org/1965943002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1965943002/diff/20001/tools/metrics/histograms/histograms.xml#newcode66790 tools/metrics/histograms/histograms.xml:66790: + <int value="4" label="Passed"/> On 2016/05/11 15:27:20, Jesse Doherty ...
4 years, 7 months ago (2016-05-11 20:04:40 UTC) #6
mdjones
lgtm
4 years, 7 months ago (2016-05-11 20:28:10 UTC) #7
jwd
lgtm
4 years, 7 months ago (2016-05-11 22:23:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965943002/40001
4 years, 7 months ago (2016-05-11 22:45:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/226196)
4 years, 7 months ago (2016-05-12 00:04:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965943002/40001
4 years, 7 months ago (2016-05-12 00:07:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 01:37:45 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 01:38:58 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bec86bbd24ae14ff54c99bfed50a3a0206a59cad
Cr-Commit-Position: refs/heads/master@{#393138}

Powered by Google App Engine
This is Rietveld 408576698