ChromeOS: Implement minumal material design OOBE.

chrome/browser/resources/chromeos/login/oobe.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Out of the box experience flow (OOBE).
  * This is the main code for the OOBE WebUI implementation.
  */
 
 <include src="login_shared.js">
@@ skipping 10 matching lines @@
 cr.define('cr.ui.Oobe', function() {
   return {
     /**
      * Setups given "select" element using the list and adds callback.
      * Creates option groups if needed.
      * @param {!Element} select Select object to be updated.
      * @param {!Object} list List of the options to be added.
      * Elements with optionGroupName are considered option group.
      * @param {string} callback Callback name which should be send to Chrome or
      * an empty string if the event listener shouldn't be added.
+     *
+     * Note: do not forget to update getSelectedTitle() below if this is
+     * updated!
      */
     setupSelect: function(select, list, callback) {
       select.innerHTML = '';
       var optgroup = select;
       for (var i = 0; i < list.length; ++i) {
         var item = list[i];
         if (item.optionGroupName) {
           optgroup = document.createElement('optgroup');
           optgroup.label = item.optionGroupName;
           select.appendChild(optgroup);
@@ skipping 13 matching lines @@
           var keycodeInterested = [
             9,  // Tab
             13,  // Enter
             27,  // Escape
           ];
           if (keycodeInterested.indexOf(event.keyCode) >= 0)
             runCallback();
         });
       }
     },
+    /**
+     * Returns title of the selected option (see setupSelect() above).
+     * @param {!Object} - the same as in setupSelect() above.
+     */
+    getSelectedTitle: function(list) {
+      var firstTitle;

[jdufault, 2016/05/11 22:07:43]

Initialize to '', and then after the for loop unconditionally return firstTitle?

'' will be treated as false in if(!firstTitle) so this change shouldn't change
behavior.

[Alexander Alekseev, 2016/05/13 20:52:34]

Done.

+      for (var i = 0; i < list.length; ++i) {
+        var item = list[i];
+        if (item.optionGroupName)
+          continue;
+
+        if (!firstTitle)
+          firstTitle = item.title;
+
+        if (item.selected)
+          return item.title;
+      }
+      if (firstTitle)
+        return firstTitle;
+
+      return '';
+    },
 
     /**
      * Initializes the OOBE flow.  This will cause all C++ handlers to
      * be invoked to do final setup.
      */
     initialize: function() {
       cr.ui.login.DisplayManager.initialize();
       login.HIDDetectionScreen.register();
       login.WrongHWIDScreen.register();
       login.NetworkScreen.register();
@@ skipping 200 matching lines @@
     reloadContent: function(data) {
       // Reload global local strings, process DOM tree again.
       loadTimeData.overrideValues(data);
       i18nTemplate.process(document, loadTimeData);
 
       // Update language and input method menu lists.
       Oobe.setupSelect($('language-select'), data.languageList);
       Oobe.setupSelect($('keyboard-select'), data.inputMethodsList);
       Oobe.setupSelect($('timezone-select'), data.timezoneList);
 
+      // ---------- Welcome screen
+      $('oobe-poly-welcome').SetOobePolyWelcomeCurrentLanguage(

[jdufault, 2016/05/11 22:07:43]

Rename method call to SetCurrentLanguage? What about just having a property set
method then, so it is

$('...').currentLanguage = Oobe.getSelectedTitle(...)

[jdufault, 2016/05/11 22:07:43]

What about oobe-welcome-md?

[Alexander Alekseev, 2016/05/13 20:52:34]

Done.

+          Oobe.getSelectedTitle(data.languageList));
+      if (data.mdOobeUI == 'on') {
+        $('oobe-classic-connect').hidden = true;

[jdufault, 2016/05/11 22:07:43]

Just oobe-connect?

[Alexander Alekseev, 2016/05/13 20:52:34]

Done.

+        $('oobe-poly-welcome').hidden = false;
+      } else {
+        $('oobe-classic-connect').hidden = false;
+        $('oobe-poly-welcome').hidden = true;
+      }
+      // ----------
+
       // Update localized content of the screens.
       Oobe.updateLocalizedContent();
     },
 
     /**
      * Updates localized content of the screens.
      * Should be executed on language change.
      */
     updateLocalizedContent: function() {
       // Buttons, headers and links.
       Oobe.getInstance().updateLocalizedContent_();
     }
   };
 });