Fix blink_perf.css.CSSPropertySetterGetter failure

Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
R=trchen@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/3a05db510a333ebcd1724213d4f7a4cbea2e73a7

[Xianzhu, 2016-05-11 18:08:32]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-05-11 18:59:37]

Description was changed from

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
==========

to

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
==========

[Xianzhu, 2016-05-11 18:59:37]

wangxianzhu@chromium.org changed reviewers:
+ trchen@chromium.org

[Xianzhu, 2016-05-11 19:01:00]

Patchset #2 (id:20001) has been deleted

[trchen, 2016-05-11 19:06:07]

lgtm.

BTW I think it should be safe to move the block to styleDidChange. Rarely we
need to have things in styleWillChange. That said, it is orthogonal to this CL.

[Xianzhu, 2016-05-11 19:07:57]

On 2016/05/11 19:06:07, trchen wrote:
> lgtm.
> 
> BTW I think it should be safe to move the block to styleDidChange. Rarely we
> need to have things in styleWillChange. That said, it is orthogonal to this
CL.

Good point. Will consider this in later changes.

[Xianzhu, 2016-05-11 19:08:02]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-05-11 19:08:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965893007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965893007/1

[commit-bot: I haz the power, 2016-05-11 19:21:07]

Description was changed from

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
==========

to

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
R=trchen@chromium.org

Committed: https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7
Cr-Commit-Position: refs/heads/master@{#393018}
==========

[commit-bot: I haz the power, 2016-05-11 19:21:08]

Patchset 1 (id:??) landed as
https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7
Cr-Commit-Position: refs/heads/master@{#393018}

[Xianzhu, 2016-05-11 19:21:54]

Description was changed from

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
R=trchen@chromium.org

Committed: https://crrev.com/3a05db510a333ebcd1724213d4f7a4cbea2e73a7
Cr-Commit-Position: refs/heads/master@{#393018}
==========

to

==========
Fix blink_perf.css.CSSPropertySetterGetter failure

LayoutBoxModelObject::styleWillChange() assumed hasLayer() when it
sees StyleDifference::needsPaintInvalidationSubtree().
https://codereview.chromium.org/1950573003/ broke the assumption.

Now check hasLayer().

Added a test based on blink_perf.css.CSSPropertySetterGetter.

BUG=611060
TEST=fast/css/css-property-setter-getter.html
R=trchen@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/3a05db510a333ebcd1724213d4f7...
==========

[Xianzhu, 2016-05-11 19:21:56]

Committed patchset #1 (id:1) manually as
3a05db510a333ebcd1724213d4f7a4cbea2e73a7 (presubmit successful).