Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1965863002: WebUI: Fix bookmark manager regression. (Closed)

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, noyau+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix bookmark manager regression. BUG=610602 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/87d0ec171e127ec7477c5d323f5e0d8715af12e5 Cr-Commit-Position: refs/heads/master@{#392656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dpapad
4 years, 7 months ago (2016-05-10 17:27:42 UTC) #3
Dan Beam
whoops lgtm (guess we have no test for bookmarks manager :/)
4 years, 7 months ago (2016-05-10 17:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965863002/1
4 years, 7 months ago (2016-05-10 18:00:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 18:24:38 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 18:27:14 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/87d0ec171e127ec7477c5d323f5e0d8715af12e5
Cr-Commit-Position: refs/heads/master@{#392656}

Powered by Google App Engine
This is Rietveld 408576698