Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1965843002: Revert of Changed Blimp client to start with white screen before drawing contents (Closed)

Created:
4 years, 7 months ago by tommycli
Modified:
4 years, 7 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Changed Blimp client to start with white screen before drawing contents (patchset #4 id:60001 of https://codereview.chromium.org/1925863003/ ) Reason for revert: Reverting because this patch broke the Dr Memory bot: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4772 Original issue's description: > Changed Blimp client to start with white screen before drawing contents > > Currently Blimp client starts with a black screen before having any > contents. In this patch, this behavior was fixed by two steps: > 1 - BlimpView background color is set to white on initialization. > 2 - Later after the first frame is received, the background is reset to > null. > For this to happen, we rely on the callback DidCompleteSwapBuffers of > RemoteChannelImpl and hook it all the way to BlimpView. > > BUG=603797 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/a14676fc06d51ce9382217801882dae19e2c792a > Cr-Commit-Position: refs/heads/master@{#391619} TBR=khushalsagar@chromium.org,nyquist@chromium.org,vmpstr@chromium.org,shaktisahu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -83 lines) Patch
M blimp/client/app/android/blimp_compositor_manager_android.h View 2 chunks +3 lines, -5 lines 0 comments Download
M blimp/client/app/android/blimp_compositor_manager_android.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M blimp/client/app/android/blimp_view.h View 3 chunks +2 lines, -5 lines 0 comments Download
M blimp/client/app/android/blimp_view.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpView.java View 4 chunks +0 lines, -10 lines 0 comments Download
M blimp/client/app/linux/blimp_display_manager.h View 3 chunks +1 line, -6 lines 0 comments Download
M blimp/client/app/linux/blimp_display_manager.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.h View 4 chunks +1 line, -9 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/feature/compositor/blimp_compositor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/remote_channel_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/remote_channel_impl.cc View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
tommycli
Created Revert of Changed Blimp client to start with white screen before drawing contents
4 years, 7 months ago (2016-05-10 17:02:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965843002/1
4 years, 7 months ago (2016-05-10 17:03:44 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:06:40 UTC) #4
Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698