Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: runtime/vm/service_event.cc

Issue 1965823002: Initial isolate reload support (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service_event.cc
diff --git a/runtime/vm/service_event.cc b/runtime/vm/service_event.cc
index c4732589efd8d69896ebb1e2dd0a9d787e977f8a..94af480e8fc45697967b94685ea18487e82ede05 100644
--- a/runtime/vm/service_event.cc
+++ b/runtime/vm/service_event.cc
@@ -22,6 +22,7 @@ ServiceEvent::ServiceEvent(Isolate* isolate, EventKind event_kind)
timeline_event_block_(NULL),
extension_rpc_(NULL),
exception_(NULL),
+ reload_error_(NULL),
at_async_jump_(false),
inspectee_(NULL),
gc_stats_(NULL),
@@ -66,6 +67,8 @@ const char* ServiceEvent::KindAsCString() const {
return "IsolateUpdate";
case kServiceExtensionAdded:
return "ServiceExtensionAdded";
+ case kIsolateReload:
+ return "IsolateReload";
case kPauseStart:
return "PauseStart";
case kPauseExit:
@@ -118,6 +121,7 @@ const StreamInfo* ServiceEvent::stream_info() const {
case kIsolateRunnable:
case kIsolateExit:
case kIsolateUpdate:
+ case kIsolateReload:
case kServiceExtensionAdded:
return &Service::isolate_stream;
@@ -171,6 +175,14 @@ const char* ServiceEvent::stream_id() const {
void ServiceEvent::PrintJSON(JSONStream* js) const {
JSONObject jsobj(js);
PrintJSONHeader(&jsobj);
+ if (kind() == kIsolateReload) {
+ if (reload_error_ == NULL) {
+ jsobj.AddProperty("status", "success");
+ } else {
+ jsobj.AddProperty("status", "failure");
+ jsobj.AddProperty("reloadError", *(reload_error()));
+ }
+ }
if (kind() == kServiceExtensionAdded) {
ASSERT(extension_rpc_ != NULL);
jsobj.AddProperty("extensionRPC", extension_rpc_->ToCString());

Powered by Google App Engine
This is Rietveld 408576698