runtime/vm/pages.cc - Issue 1965823002: Initial isolate reload support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.cc

Issue 1965823002: Initial isolate reload support (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/pages.cc

diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc

index 9c0352fe274a161ecbc4babb9878833e327df766..e5d1e65f0839aae645ed145b6557025dc43b69c5 100644

--- a/runtime/vm/pages.cc

+++ b/runtime/vm/pages.cc

@@ -844,7 +844,9 @@ void PageSpace::MarkSweep(bool invoke_api_callbacks) {

SpaceUsage usage_before = GetCurrentUsage();

// Mark all reachable old-gen objects.

- bool collect_code = FLAG_collect_code && ShouldCollectCode();

+ bool collect_code = FLAG_collect_code &&

+ ShouldCollectCode() &&

+ !isolate->HasAttemptedReload();

GCMarker marker(heap_);

marker.MarkObjects(isolate, this, invoke_api_callbacks, collect_code);

usage_.used_in_words = marker.marked_words();