runtime/vm/flow_graph_compiler_x64.cc - Issue 1965823002: Initial isolate reload support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1965823002: Initial isolate reload support (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index c8ce4f5d248d4d8ce1df9a2dd9862c1356434177..b76da0bd5446e06db9b12bfa7c4caf97e12d47ee 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -442,8 +442,8 @@ RawSubtypeTestCache* FlowGraphCompiler::GenerateSubtype1TestCacheLookup(

// R10: instance class.

// Check immediate superclass equality.

__ movq(R13, FieldAddress(R10, Class::super_type_offset()));

- __ movq(R13, FieldAddress(R13, Type::type_class_offset()));

- __ CompareObject(R13, type_class);

+ __ movq(R13, FieldAddress(R13, Type::type_class_id_offset()));

+ __ CompareImmediate(R13, Immediate(Smi::RawValue(type_class.id())));

__ j(EQUAL, is_instance_lbl);

const Register kTypeArgumentsReg = kNoRegister;