Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1965803002: [compiler] Remove dead disabling of optimizations. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
mvstanton, neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove dead disabling of optimizations. The AstNumberingVisitor is by now strictly running after we allocated the SharedFunctionInfo. This removes some left-over code from before that invariant was holding. R=mvstanton@chromium.org Committed: https://crrev.com/f002cee0db841b11e08da4d9e3db7e3c71f4a785 Cr-Commit-Position: refs/heads/master@{#36928}

Patch Set 1 #

Patch Set 2 : One more setter. #

Patch Set 3 : Fix asm.js validator. #

Patch Set 4 : Rebaed. #

Patch Set 5 : Reduce to essence. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/objects.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-10 15:18:20 UTC) #2
Michael Starzinger
PTAL. I reduced this CL down to the essential. Ready for prime time. +Georg: FYI, ...
4 years, 6 months ago (2016-06-13 11:32:39 UTC) #4
mvstanton
lgtm
4 years, 6 months ago (2016-06-13 12:04:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965803002/100001
4 years, 6 months ago (2016-06-13 12:28:10 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 6 months ago (2016-06-13 12:30:17 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:31:33 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f002cee0db841b11e08da4d9e3db7e3c71f4a785
Cr-Commit-Position: refs/heads/master@{#36928}

Powered by Google App Engine
This is Rietveld 408576698