Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/hydrogen.h

Issue 19658004: Replace BuildExternalArrayElementAccess() with AddExternalArrayElementAccess(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1028 matching lines...) Expand 10 before | Expand all | Expand 10 after
1039 protected: 1039 protected:
1040 virtual bool BuildGraph() = 0; 1040 virtual bool BuildGraph() = 0;
1041 1041
1042 HBasicBlock* CreateBasicBlock(HEnvironment* env); 1042 HBasicBlock* CreateBasicBlock(HEnvironment* env);
1043 HBasicBlock* CreateLoopHeaderBlock(); 1043 HBasicBlock* CreateLoopHeaderBlock();
1044 1044
1045 HValue* BuildCheckHeapObject(HValue* object); 1045 HValue* BuildCheckHeapObject(HValue* object);
1046 HValue* BuildCheckMap(HValue* obj, Handle<Map> map); 1046 HValue* BuildCheckMap(HValue* obj, Handle<Map> map);
1047 1047
1048 // Building common constructs 1048 // Building common constructs
1049 HInstruction* BuildExternalArrayElementAccess(
1050 HValue* external_elements,
1051 HValue* checked_key,
1052 HValue* val,
1053 HValue* dependency,
1054 ElementsKind elements_kind,
1055 bool is_store);
1056
1057 HValue* BuildCheckForCapacityGrow(HValue* object, 1049 HValue* BuildCheckForCapacityGrow(HValue* object,
1058 HValue* elements, 1050 HValue* elements,
1059 ElementsKind kind, 1051 ElementsKind kind,
1060 HValue* length, 1052 HValue* length,
1061 HValue* key, 1053 HValue* key,
1062 bool is_js_array); 1054 bool is_js_array);
1063 1055
1064 HValue* BuildCopyElementsOnWrite(HValue* object, 1056 HValue* BuildCopyElementsOnWrite(HValue* object,
1065 HValue* elements, 1057 HValue* elements,
1066 ElementsKind kind, 1058 ElementsKind kind,
(...skipping 20 matching lines...) Expand all
1087 HValue *object, 1079 HValue *object,
1088 HObjectAccess access, 1080 HObjectAccess access,
1089 HValue *typecheck = NULL, 1081 HValue *typecheck = NULL,
1090 Representation representation = Representation::Tagged()); 1082 Representation representation = Representation::Tagged());
1091 1083
1092 HLoadNamedField* BuildLoadNamedField( 1084 HLoadNamedField* BuildLoadNamedField(
1093 HValue* object, 1085 HValue* object,
1094 HObjectAccess access, 1086 HObjectAccess access,
1095 Representation representation); 1087 Representation representation);
1096 1088
1089 HInstruction* AddExternalArrayElementAccess(
1090 HValue* external_elements,
1091 HValue* checked_key,
1092 HValue* val,
1093 HValue* dependency,
1094 ElementsKind elements_kind,
1095 bool is_store);
1096
1097 HInstruction* AddFastElementAccess( 1097 HInstruction* AddFastElementAccess(
1098 HValue* elements, 1098 HValue* elements,
1099 HValue* checked_key, 1099 HValue* checked_key,
1100 HValue* val, 1100 HValue* val,
1101 HValue* dependency, 1101 HValue* dependency,
1102 ElementsKind elements_kind, 1102 ElementsKind elements_kind,
1103 bool is_store, 1103 bool is_store,
1104 LoadKeyedHoleMode load_mode, 1104 LoadKeyedHoleMode load_mode,
1105 KeyedAccessStoreMode store_mode); 1105 KeyedAccessStoreMode store_mode);
1106 1106
(...skipping 988 matching lines...) Expand 10 before | Expand all | Expand 10 after
2095 EmbeddedVector<char, 64> filename_; 2095 EmbeddedVector<char, 64> filename_;
2096 HeapStringAllocator string_allocator_; 2096 HeapStringAllocator string_allocator_;
2097 StringStream trace_; 2097 StringStream trace_;
2098 int indent_; 2098 int indent_;
2099 }; 2099 };
2100 2100
2101 2101
2102 } } // namespace v8::internal 2102 } } // namespace v8::internal
2103 2103
2104 #endif // V8_HYDROGEN_H_ 2104 #endif // V8_HYDROGEN_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698