Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: LayoutTests/media/video-frame-size-change.html

Issue 196573042: Remove display() from more layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/misc/slow-loading-image-in-pattern.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/video-frame-size-change.html
diff --git a/LayoutTests/media/video-frame-size-change.html b/LayoutTests/media/video-frame-size-change.html
index ae4513f62176f8c276200486bebddd3a86d1b76f..99dfa495f835bbe7060ed761ddcecae43c88bcc9 100644
--- a/LayoutTests/media/video-frame-size-change.html
+++ b/LayoutTests/media/video-frame-size-change.html
@@ -5,7 +5,7 @@
as opposed to changing the size of the element.</p>
<video width="320"></video>
<video></video>
-
+ <script src="../resources/run-after-display.js"></script>
<script>
if (window.testRunner) {
testRunner.waitUntilDone();
@@ -49,15 +49,12 @@
}
}
- // Make sure we render the first frame.
- if (window.testRunner) {
- testRunner.display();
- }
-
- video.play();
- video_fixed_size.play();
- video.removeEventListener('canplay', oncanplay);
- video_fixed_size.removeEventListener('canplay', oncanplay);
+ runAfterDisplay(function() {
scherkus (not reviewing) 2014/03/19 20:20:35 some notes on this test as I was the one who wrote
enne (OOO) 2014/03/19 20:22:34 The frame size changes happen during painting and
+ video.play();
+ video_fixed_size.play();
+ video.removeEventListener('canplay', oncanplay);
+ video_fixed_size.removeEventListener('canplay', oncanplay);
+ });
};
video.addEventListener('canplay', oncanplay);
video_fixed_size.addEventListener('canplay', oncanplay);
« no previous file with comments | « LayoutTests/http/tests/misc/slow-loading-image-in-pattern.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698