LayoutTests/fast/replaced/width100percent-textarea.html - Issue 196573042: Remove display() from more layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/replaced/width100percent-textarea.html

Issue 196573042: Remove display() from more layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove video-frame-size-change test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/animation/request-animation-frame-during-modal.html ('K') | « LayoutTests/fast/reflections/inline-crash.html ('k') | LayoutTests/fast/text/font-initial.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <style>	3 <style>

4 .test { width: 100%; }	4 .test { width: 100%; }

5 </style>	5 </style>

6 </head>	6 </head>

7 <body>	7 <body>

8 <script>

9 if (window.testRunner)

10 testRunner.display();
ojan 2014/03/27 20:31:49 Does removing this not change behavior? Didn't thi Does removing this not change behavior? Didn't this used to paint the overlay and then paint the table contents on top of that? Now, I'm not sure why that's actually useful. enne (OOO) 2014/03/27 20:51:05 Yeah, I don't think it's useful either. It does c Show quoted text On 2014/03/27 20:31:49, ojan wrote: > Does removing this not change behavior? Didn't this used to paint the overlay > and then paint the table contents on top of that? > > Now, I'm not sure why that's actually useful. Yeah, I don't think it's useful either. It does change behavior, but I don't think this test is attempting to check for over repainting (since it invalidates the entire page as it adds the elements below after the display. The text indicates it's only looking for the final pixel output.
11 </script>

12

13 The textareas below should not overlap.	8 The textareas below should not overlap.

14 <table border="0" cellspacing="1" cellpadding="1" width="100%">	9 <table border="0" cellspacing="1" cellpadding="1" width="100%">

15 <tr>	10 <tr>

16 <td nowrap><textarea class="test">one</textarea></td>	11 <td nowrap><textarea class="test">one</textarea></td>

17 <td><textarea class="test">two</textarea></td>	12 <td><textarea class="test">two</textarea></td>

18 <td><textarea class="test">three</textarea></td>	13 <td><textarea class="test">three</textarea></td>

19 <td width="100%"> </td>	14 <td width="100%"> </td>

20 </tr>	15 </tr>

21 </table>	16 </table>

22	17

23 <br>	18 <br>

24 <br>	19 <br>

25	20

26 <table border="0" cellspacing="1" cellpadding="1" width="100%">	21 <table border="0" cellspacing="1" cellpadding="1" width="100%">

27 <tr>	22 <tr>

28 <td nowrap><textarea class="test" cols="30">one two three</textarea></td>	23 <td nowrap><textarea class="test" cols="30">one two three</textarea></td>

29 <td><textarea class="test" cols="30">two</textarea></td>	24 <td><textarea class="test" cols="30">two</textarea></td>

30 <td><textarea class="test" cols="30">three</textarea></td>	25 <td><textarea class="test" cols="30">three</textarea></td>

31 <td width="100%"> </td>	26 <td width="100%"> </td>

32 </tr>	27 </tr>

33 </table>	28 </table>

34	29

35 </body>	30 </body>

36 </html>	31 </html>

OLD	NEW