LayoutTests/fast/animation/request-animation-frame-during-modal.html - Issue 196573042: Remove display() from more layout tests

Side by Side Diff: LayoutTests/fast/animation/request-animation-frame-during-modal.html

Issue 196573042: Remove display() from more layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove video-frame-size-change test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/css3/filters/multiple-filters-invalidation.html ('K') | « LayoutTests/css3/filters/multiple-filters-invalidation.html ('k') | LayoutTests/fast/canvas/webgl/canvas-test.html » ('j') | LayoutTests/fast/replaced/width100percent-textarea.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <script src="../../resources/js-test.js"></script>	3 <script src="../../resources/js-test.js"></script>

4 <body>	4 <body>

5	5

6 <script type="text/javascript">	6 <script type="text/javascript">

7 if (window.testRunner)	7 if (window.testRunner)

8 testRunner.setCanOpenWindows();	8 testRunner.setCanOpenWindows();

9	9

10 description('Tests that requestAnimationFrame callbacks are not invoked while mo dal dialogs are displayed.');	10 description('Tests that requestAnimationFrame callbacks are not invoked while mo dal dialogs are displayed.');

11	11

12 onload = function()	12 onload = function()

13 {	13 {

14 debug('Setting callback');	14 debug('Setting callback');

15 window.requestAnimationFrame(function() { debug('Callback fired'); }, docume nt.body);	15 window.requestAnimationFrame(function() { debug('Callback fired'); }, docume nt.body);

16 debug('Showing modal dialog');	16 debug('Showing modal dialog');

17 var src = 'if (window.testRunner) {' +	17 var src = 'window.setTimeout(window.close, 100);';
	ojan 2014/03/27 20:31:49 Why 100ms? This seems fragile and likely to be fla Why 100ms? This seems fragile and likely to be flaky. Maybe we don't care since we're getting rid of showModalDialog in a couple weeks? enne (OOO) 2014/03/27 20:51:05 Yeah, it's a magic number. Since raf can't be inv Show quoted text On 2014/03/27 20:31:49, ojan wrote: > Why 100ms? This seems fragile and likely to be flaky. > > Maybe we don't care since we're getting rid of showModalDialog in a couple > weeks? Yeah, it's a magic number. Since raf can't be invoked while in a modal dialog, I can't use raf and have to fall back on setTimeout. This test is trying to make sure that raf is not invoked while a modal dialog is up. raf should almost certianly run within 100ms, so it seemed like a reasonable period of time to wait. Do you have a better suggestion? ojan 2014/03/27 21:58:45 Can you requestAnimationFrame inside the showModal Show quoted text On 2014/03/27 20:51:05, enne wrote: > On 2014/03/27 20:31:49, ojan wrote: > > Why 100ms? This seems fragile and likely to be flaky. > > > > Maybe we don't care since we're getting rid of showModalDialog in a couple > > weeks? > > Yeah, it's a magic number. Since raf can't be invoked while in a modal dialog, > I can't use raf and have to fall back on setTimeout. > > This test is trying to make sure that raf is not invoked while a modal dialog is > up. raf should almost certianly run within 100ms, so it seemed like a > reasonable period of time to wait. > > Do you have a better suggestion? Can you requestAnimationFrame inside the showModalDialog? I guess that doesn't guarantee that we would have tried to put up a frame in the parent page. Meh. Not worth worrying about. enne (OOO) 2014/03/27 22:03:05 There's a rAF right before it. Since showModalDia Show quoted text On 2014/03/27 21:58:45, ojan wrote: > On 2014/03/27 20:51:05, enne wrote: > > On 2014/03/27 20:31:49, ojan wrote: > > > Why 100ms? This seems fragile and likely to be flaky. > > > > > > Maybe we don't care since we're getting rid of showModalDialog in a couple > > > weeks? > > > > Yeah, it's a magic number. Since raf can't be invoked while in a modal > dialog, > > I can't use raf and have to fall back on setTimeout. > > > > This test is trying to make sure that raf is not invoked while a modal dialog > is > > up. raf should almost certianly run within 100ms, so it seemed like a > > reasonable period of time to wait. > > > > Do you have a better suggestion? > > Can you requestAnimationFrame inside the showModalDialog? I guess that doesn't > guarantee that we would have tried to put up a frame in the parent page. There's a rAF right before it. Since showModalDialog is synchronous, then that's equivalent to it being inside, I think. Show quoted text > Meh. Not worth worrying about. Yeah, my thought exactly.
18 ' testRunner.display();' +

19 ' window.close();' +

20 '} else {'+

21 ' window.setTimeout(window.close, 10);'+

22 '}';

23 showModalDialog('data:text/html,<script>' + src + '</' + 'script>');	18 showModalDialog('data:text/html,<script>' + src + '</' + 'script>');

24 debug('Returned from modal dialog');	19 debug('Returned from modal dialog');

25 if (window.testRunner) {;

26 testRunner.display();

27 }

28	20

29 window.requestAnimationFrame(function() {	21 window.requestAnimationFrame(function() {

30 isSuccessfullyParsed();	22 isSuccessfullyParsed();

31 if (window.testRunner)	23 if (window.testRunner)

32 testRunner.notifyDone();	24 testRunner.notifyDone();

33 });	25 });

34 }	26 }

35	27

36 if (window.testRunner)	28 if (window.testRunner)

37 testRunner.waitUntilDone();	29 testRunner.waitUntilDone();

38	30

39 </script>	31 </script>

40 </body>	32 </body>

41 </html>	33 </html>

42	34

OLD	NEW