Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 196573041: Remove force push from GitCheckout.commit() (Closed)

Created:
6 years, 9 months ago by agable
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove force push from GitCheckout.commit() The CQ should not be able to force push -- this allows it to wipe out legitimate commits if something goes wrong internally. This happened recently, with a CQ commit orphaning 20 commits from the previous few days. This may have happened any number of times previously, probably only wiping out one commit at a time, whenever there was a race between the CQ and a developer's direct commit+push. Repositories should also protect themselves by disallowing force push in their ACLs. BUG=261619 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=258092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M checkout.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
agable
6 years, 9 months ago (2014-03-19 19:14:40 UTC) #1
M-A Ruel
lgtm
6 years, 9 months ago (2014-03-19 19:17:57 UTC) #2
Sergey Berezin
lgtm
6 years, 9 months ago (2014-03-19 19:19:21 UTC) #3
rmistry
On 2014/03/19 19:19:21, Sergey Berezin wrote: > lgtm LGTM
6 years, 9 months ago (2014-03-19 19:46:44 UTC) #4
iannucci
On 2014/03/19 19:46:44, rmistry wrote: > On 2014/03/19 19:19:21, Sergey Berezin wrote: > > lgtm ...
6 years, 9 months ago (2014-03-19 20:11:02 UTC) #5
agable
The CQ bit was checked by agable@chromium.org
6 years, 9 months ago (2014-03-19 21:05:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/196573041/1
6 years, 9 months ago (2014-03-19 21:05:52 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 21:07:40 UTC) #8
Message was sent while issue was closed.
Change committed as 258092

Powered by Google App Engine
This is Rietveld 408576698