Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: build/common.gypi

Issue 196573022: Use gold from third_party/binutils rather then third_party/gold. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding --disable-new-dtags flag. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1327 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 # Set to 1 to compile with MSE support for MPEG2 TS 1338 # Set to 1 to compile with MSE support for MPEG2 TS
1339 'enable_mpeg2ts_stream_parser%': 0, 1339 'enable_mpeg2ts_stream_parser%': 0,
1340 1340
1341 'conditions': [ 1341 'conditions': [
1342 # Enable the Syzygy optimization step for the official builds. 1342 # Enable the Syzygy optimization step for the official builds.
1343 ['OS=="win" and buildtype=="Official" and syzyasan!=1', { 1343 ['OS=="win" and buildtype=="Official" and syzyasan!=1', {
1344 'syzygy_optimize%': 1, 1344 'syzygy_optimize%': 1,
1345 }, { 1345 }, {
1346 'syzygy_optimize%': 0, 1346 'syzygy_optimize%': 0,
1347 }], 1347 }],
1348 1348 # Get binutils version so we can enable debug fission if we can.
1349 ['os_posix==1 and OS!="mac" and OS!="ios"', {
1350 'conditions': [
1351 # compiler_version doesn't work with clang
1352 # TODO(mithro): Land https://codereview.chromium.org/199793014/ so
1353 # compiler_version works with clang.
1354 # TODO(glider): set clang to 1 earlier for ASan and TSan builds so
1355 # that it takes effect here.
1356 ['clang==0 and asan==0 and lsan==0 and tsan==0 and msan==0', {
1357 'binutils_version%': '<!(python <(DEPTH)/build/compiler_version.py a ssembler)',
1358 }],
1359 # On Android we know the binutils version in the toolchain.
1360 ['OS=="android"', {
1361 'binutils_version%': 222,
1362 }],
1363 # Our version of binutils in third_party/binutils
1364 ['linux_use_gold_binary==1', {
1365 'binutils_version%': 224,
1366 'conditions': [
1367 ['host_arch=="x64"', {
1368 'binutils_dir%': 'third_party/binutils/Linux_x64/Release/bin',
1369 }],
1370 ['host_arch=="ia32"', {
1371 'binutils_dir%': 'third_party/binutils/Linux_ia32/Release/bin',
1372 }],
1373 ],
1374 }],
1375 ],
1376 }, {
1377 'binutils_version%': 0,
1378 }],
1349 # The version of GCC in use, set later in platforms that use GCC and have 1379 # The version of GCC in use, set later in platforms that use GCC and have
1350 # not explicitly chosen to build with clang. Currently, this means all 1380 # not explicitly chosen to build with clang. Currently, this means all
1351 # platforms except Windows, Mac and iOS. 1381 # platforms except Windows, Mac and iOS.
1352 # TODO(glider): set clang to 1 earlier for ASan and TSan builds so that 1382 # TODO(glider): set clang to 1 earlier for ASan and TSan builds so that
1353 # it takes effect here. 1383 # it takes effect here.
1354 ['os_posix==1 and OS!="mac" and OS!="ios" and clang==0 and asan==0 and lsa n==0 and tsan==0 and msan==0', { 1384 ['os_posix==1 and OS!="mac" and OS!="ios" and clang==0 and asan==0 and lsa n==0 and tsan==0 and msan==0', {
1355 'conditions': [ 1385 'conditions': [
1356 ['OS=="android"', { 1386 ['OS=="android"', {
1357 # We directly set the gcc_version since we know what we use. 1387 # We directly set the gcc_version since we know what we use.
1358 'conditions': [ 1388 'conditions': [
1359 ['target_arch=="x64" or target_arch=="arm64"', { 1389 ['target_arch=="x64" or target_arch=="arm64"', {
1360 'gcc_version%': 48, 1390 'gcc_version%': 48,
1361 }, { 1391 }, {
1362 'gcc_version%': 46, 1392 'gcc_version%': 46,
1363 }], 1393 }],
1364 ], 1394 ],
1365 'binutils_version%': 222,
1366 }, { 1395 }, {
1367 'gcc_version%': '<!(python <(DEPTH)/build/compiler_version.py)', 1396 'gcc_version%': '<!(python <(DEPTH)/build/compiler_version.py)',
1368 'binutils_version%': '<!(python <(DEPTH)/build/compiler_version.py a ssembler)',
1369 }], 1397 }],
1370 ], 1398 ],
1371 }, { 1399 }, {
1372 'gcc_version%': 0, 1400 'gcc_version%': 0,
1373 'binutils_version%': 0,
1374 }], 1401 }],
1375 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(windows_sdk_defa ult_path))"=="True"', { 1402 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(windows_sdk_defa ult_path))"=="True"', {
1376 'windows_sdk_path%': '<(windows_sdk_default_path)', 1403 'windows_sdk_path%': '<(windows_sdk_default_path)',
1377 }, { 1404 }, {
1378 'windows_sdk_path%': 'C:/Program Files (x86)/Windows Kits/8.0', 1405 'windows_sdk_path%': 'C:/Program Files (x86)/Windows Kits/8.0',
1379 }], 1406 }],
1380 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(directx_sdk_defa ult_path))"=="True"', { 1407 ['OS=="win" and "<!(python <(DEPTH)/build/dir_exists.py <(directx_sdk_defa ult_path))"=="True"', {
1381 'directx_sdk_path%': '<(directx_sdk_default_path)', 1408 'directx_sdk_path%': '<(directx_sdk_default_path)',
1382 }, { 1409 }, {
1383 'directx_sdk_path%': '$(DXSDK_DIR)', 1410 'directx_sdk_path%': '$(DXSDK_DIR)',
(...skipping 2459 matching lines...) Expand 10 before | Expand all | Expand 10 after
3843 # now. 3870 # now.
3844 #'-Wl,--icf=safe', 3871 #'-Wl,--icf=safe',
3845 '-Wl,--icf=none', 3872 '-Wl,--icf=none',
3846 ], 3873 ],
3847 }], 3874 }],
3848 ], 3875 ],
3849 }], 3876 }],
3850 ], 3877 ],
3851 }], 3878 }],
3852 ['linux_use_gold_binary==1', { 3879 ['linux_use_gold_binary==1', {
3880 # Put our binutils, which contains gold in the search path. We pass
3881 # the path to gold to the compiler. gyp leaves unspecified what the
3882 # cwd is when running the compiler, so the normal gyp path-munging
3883 # fails us. This hack gets the right path.
3884 'cflags': [
3885 '-B<!(cd <(DEPTH) && pwd -P)/<(binutils_dir)',
3886 ],
3853 'ldflags': [ 3887 'ldflags': [
3854 # Put our gold binary in the search path for the linker. 3888 '-B<!(cd <(DEPTH) && pwd -P)/<(binutils_dir)',
3855 # We pass the path to gold to the compiler. gyp leaves
3856 # unspecified what the cwd is when running the compiler,
3857 # so the normal gyp path-munging fails us. This hack
3858 # gets the right path.
3859 '-B<!(cd <(DEPTH) && pwd -P)/third_party/gold',
3860 ], 3889 ],
3861 }], 3890 }],
3891 ['binutils_version>=224', {
3892 # Newer binutils don't set DT_RPATH unless you disable "new" dtags
3893 # and the new DT_RUNPATH doesn't work without --no-as-needed flag.
3894 # FIXME(mithro): Figure out the --as-needed/--no-as-needed flags
3895 # inside this file to allow usage of --no-as-needed and removal of
3896 # this flag.
3897 'ldflags': [
3898 '-Wl,--disable-new-dtags',
3899 ],
3900 }]
3862 ], 3901 ],
3863 }, 3902 },
3864 }], 3903 }],
3865 # FreeBSD-specific options; note that most FreeBSD options are set above, 3904 # FreeBSD-specific options; note that most FreeBSD options are set above,
3866 # with Linux. 3905 # with Linux.
3867 ['OS=="freebsd"', { 3906 ['OS=="freebsd"', {
3868 'target_defaults': { 3907 'target_defaults': {
3869 'ldflags': [ 3908 'ldflags': [
3870 '-Wl,--no-keep-memory', 3909 '-Wl,--no-keep-memory',
3871 ], 3910 ],
(...skipping 1338 matching lines...) Expand 10 before | Expand all | Expand 10 after
5210 # settings in target dicts. SYMROOT is a special case, because many other 5249 # settings in target dicts. SYMROOT is a special case, because many other
5211 # Xcode variables depend on it, including variables such as 5250 # Xcode variables depend on it, including variables such as
5212 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5251 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5213 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5252 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5214 # files to appear (when present) in the UI as actual files and not red 5253 # files to appear (when present) in the UI as actual files and not red
5215 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5254 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5216 # and therefore SYMROOT, needs to be set at the project level. 5255 # and therefore SYMROOT, needs to be set at the project level.
5217 'SYMROOT': '<(DEPTH)/xcodebuild', 5256 'SYMROOT': '<(DEPTH)/xcodebuild',
5218 }, 5257 },
5219 } 5258 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698